Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/expire_history_backend_unittest.cc
diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc
index 405066e687c55f5b4bfbe5e78fdad72777f9e264..22437b563f12428941e12021a9829afe436ee585 100644
--- a/chrome/browser/history/expire_history_backend_unittest.cc
+++ b/chrome/browser/history/expire_history_backend_unittest.cc
@@ -29,6 +29,7 @@
#include "components/bookmarks/core/browser/bookmark_model.h"
#include "components/bookmarks/core/browser/bookmark_utils.h"
#include "components/bookmarks/core/test/test_bookmark_client.h"
+#include "components/history/core/browser/test_history_client.h"
#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
@@ -60,7 +61,7 @@ class ExpireHistoryTest : public testing::Test,
: bookmark_model_(bookmark_client_.CreateModel(false)),
ui_thread_(BrowserThread::UI, &message_loop_),
db_thread_(BrowserThread::DB, &message_loop_),
- expirer_(this, bookmark_model_.get()),
+ expirer_(this, &history_client_),
now_(Time::Now()) {}
protected:
@@ -102,6 +103,7 @@ class ExpireHistoryTest : public testing::Test,
// This must be destroyed last.
base::ScopedTempDir tmp_dir_;
+ TestHistoryClient history_client_;
test::TestBookmarkClient bookmark_client_;
scoped_ptr<BookmarkModel> bookmark_model_;

Powered by Google App Engine
This is Rietveld 408576698