Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: components/history.gypi

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android unit tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/history/core/browser/history_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history.gypi
diff --git a/components/history.gypi b/components/history.gypi
index 8b7821e917461b88a2923a1f0bf35398189c634a..1a17a6c962bc7a4aa459a89d25860ddf43bd9b32 100644
--- a/components/history.gypi
+++ b/components/history.gypi
@@ -6,16 +6,34 @@
'targets': [
{
'target_name': 'history_core_browser',
- 'type': 'none',
+ 'type': 'static_library',
'include_dirs': [
'..',
],
'dependencies': [
'../base/base.gyp:base',
+ '../url/url.gyp:url_lib',
'keyed_service_core',
],
'sources': [
'history/core/browser/history_client.h',
+ 'history/core/browser/history_client.cc',
+ ],
+ },
+ {
+ 'target_name': 'history_core_test_support',
+ 'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ ],
+ 'dependencies': [
+ 'history_core_browser',
+ '../base/base.gyp:base',
+ '../url/url.gyp:url_lib',
+ ],
+ 'sources': [
+ 'history/core/test/history_client_fake_bookmarks.cc',
+ 'history/core/test/history_client_fake_bookmarks.h',
],
},
],
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/history/core/browser/history_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698