Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4371)

Unified Diff: chrome/browser/history/history_service_factory.cc

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android unit tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service_factory.cc
diff --git a/chrome/browser/history/history_service_factory.cc b/chrome/browser/history/history_service_factory.cc
index 79b507432d7371000eb8fad8ca27a2b622936966..35f4493d3cedde8ef7673eeb11e49feeec5a0d2d 100644
--- a/chrome/browser/history/history_service_factory.cc
+++ b/chrome/browser/history/history_service_factory.cc
@@ -60,7 +60,6 @@ void HistoryServiceFactory::ShutdownForProfile(Profile* profile) {
HistoryServiceFactory::HistoryServiceFactory()
: BrowserContextKeyedServiceFactory(
"HistoryService", BrowserContextDependencyManager::GetInstance()) {
- DependsOn(BookmarkModelFactory::GetInstance());
DependsOn(ChromeHistoryClientFactory::GetInstance());
}
@@ -72,8 +71,7 @@ KeyedService* HistoryServiceFactory::BuildServiceInstanceFor(
Profile* profile = static_cast<Profile*>(context);
HistoryService* history_service = new HistoryService(
ChromeHistoryClientFactory::GetForProfile(profile), profile);
- if (!history_service->Init(profile->GetPath(),
- BookmarkModelFactory::GetForProfile(profile))) {
+ if (!history_service->Init(profile->GetPath())) {
return NULL;
}
return history_service;
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698