chrome/browser/history/chrome_history_client.h - Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/chrome_history_client.h

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android unit tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/android_provider_backend_unittest.cc ('k') | chrome/browser/history/chrome_history_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/chrome_history_client.h

diff --git a/chrome/browser/history/chrome_history_client.h b/chrome/browser/history/chrome_history_client.h

index f6f8d35f1ee3881ae7923044b7537f6a906db91a..24fc1d37a3e47a86479c86dad0671a6f98d444d3 100644

--- a/chrome/browser/history/chrome_history_client.h

+++ b/chrome/browser/history/chrome_history_client.h

@@ -8,11 +8,27 @@

#include "base/macros.h"

#include "components/history/core/browser/history_client.h"

+class BookmarkModel;

+// This class implements history::HistoryClient to abstract operations that

+// depend on Chrome environment.

class ChromeHistoryClient : public history::HistoryClient {

public:

- ChromeHistoryClient();

+ explicit ChromeHistoryClient(BookmarkModel* bookmark_model);

+ // history::HistoryClient:

+ virtual void BlockUntilBookmarksLoaded() OVERRIDE;

+ virtual bool IsBookmarked(const GURL& url) OVERRIDE;

+ virtual void GetBookmarks(

+ std::vector<history::URLAndTitle>* bookmarks) OVERRIDE;

+ // KeyedService:

+ virtual void Shutdown() OVERRIDE;

+ private:

+ // The BookmarkModel, this should outlive ChromeHistoryClient.

+ BookmarkModel* bookmark_model_;

- protected:

DISALLOW_COPY_AND_ASSIGN(ChromeHistoryClient);

};