components/history.gypi - Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/history.gypi

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'history_core_browser',

	9 'type': 'static_library',

	10 'include_dirs': [

	11 '..',

	12 ],

	13 'dependencies': [

	14 '../base/base.gyp:base',

	15 '../url/url.gyp:url_lib',

	16 ],

	17 'sources': [

	18 'history/core/browser/history_client.h',

	19 'history/core/browser/history_client.cc',

	20 ],

	21 },

	22 {

	23 'target_name': 'history_core_test_support',

	24 'type': 'static_library',

	25 'include_dirs': [

	26 '..',

	27 ],

	28 'dependencies': [

	29 'history_core_browser',

	30 '../base/base.gyp:base',

	31 '../url/url.gyp:url_lib',

	32 ],

	33 'sources': [

	34 'history/core/browser/history_client_mock_bookmarks.cc',
	blundell 2014/05/26 07:16:58 We're moving to a structure where the support code We're moving to a structure where the support code lives in //components/history/core/test (cf. discussions around //components/bookmarks). sdefresne 2014/05/26 16:34:02 Done. Show quoted text On 2014/05/26 07:16:58, blundell wrote: > We're moving to a structure where the support code lives in > //components/history/core/test (cf. discussions around //components/bookmarks). Done.
	35 'history/core/browser/history_client_mock_bookmarks.h',

	36 'history/core/browser/test_history_client.cc',

	37 'history/core/browser/test_history_client.h',

	38 ],

	39 },

	40 ],

	41 }

OLD	NEW

« no previous file with comments | « components/components.gyp ('k') | components/history/core/browser/history_client.h » ('j') | components/history/core/browser/history_client.h » ('J')