Abstract history dependencies on bookmarks through HistoryClient

chrome/browser/history/chrome_history_client.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_
+#define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/history/history_service.h"

[Jiang Jiang, 2014/05/19 21:51:50]

Forward declare is enough.

[sdefresne, 2014/05/23 10:02:49]

Done.

+#include "components/history/core/browser/history_client.h"
+#include "components/keyed_service/core/keyed_service.h"
+
+class Profile;
+class HistoryService;
+
+namespace history {
+
+class ChromeHistoryClient : public HistoryClient,
+                            public KeyedService {
+ public:
+  ChromeHistoryClient(Profile* profile);
+
+  HistoryService* history_service() {

[Jiang Jiang, 2014/05/19 21:51:50]

Should be a const?

[sdefresne, 2014/05/23 10:02:49]

Done.

+    return history_service_.get();
+  }
+
+  // HistoryClient:
+  virtual bool IsBookmarked(const GURL& url) OVERRIDE;
+  virtual void GetBookmarks(std::vector<URLAndTitle>* bookmarks) OVERRIDE;
+
+  // KeyedService:
+  virtual void Shutdown() OVERRIDE;
+
+ private:
+  scoped_ptr<HistoryService> history_service_;
+  Profile* profile_;
+};
+
+}  // namespace history
+
+#endif  // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_