Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: chrome/browser/history/chrome_history_client_factory.h

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android unit tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_ 5 #ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_
6 #define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_ 6 #define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_
7 7
8 #include "base/memory/singleton.h"
9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 8 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
10 9
10 template <typename T>
11 struct DefaultSingletonTraits;
12
11 class ChromeHistoryClient; 13 class ChromeHistoryClient;
12 class Profile; 14 class Profile;
13 15
14 // Singleton that owns all ChromeHistoryClients and associates them with 16 // Singleton that owns all ChromeHistoryClients and associates them with
15 // Profiles. 17 // Profiles.
16 class ChromeHistoryClientFactory : public BrowserContextKeyedServiceFactory { 18 class ChromeHistoryClientFactory : public BrowserContextKeyedServiceFactory {
17 public: 19 public:
18 static ChromeHistoryClient* GetForProfile(Profile* profile); 20 static ChromeHistoryClient* GetForProfile(Profile* profile);
19 21
20 static ChromeHistoryClientFactory* GetInstance(); 22 static ChromeHistoryClientFactory* GetInstance();
21 23
22 private: 24 private:
23 friend struct DefaultSingletonTraits<ChromeHistoryClientFactory>; 25 friend struct DefaultSingletonTraits<ChromeHistoryClientFactory>;
24 26
25 ChromeHistoryClientFactory(); 27 ChromeHistoryClientFactory();
26 virtual ~ChromeHistoryClientFactory(); 28 virtual ~ChromeHistoryClientFactory();
27 29
28 // BrowserContextKeyedServiceFactory: 30 // BrowserContextKeyedServiceFactory:
29 virtual KeyedService* BuildServiceInstanceFor( 31 virtual KeyedService* BuildServiceInstanceFor(
30 content::BrowserContext* context) const OVERRIDE; 32 content::BrowserContext* context) const OVERRIDE;
31 virtual content::BrowserContext* GetBrowserContextToUse( 33 virtual content::BrowserContext* GetBrowserContextToUse(
32 content::BrowserContext* context) const OVERRIDE; 34 content::BrowserContext* context) const OVERRIDE;
33 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE; 35 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;
34 }; 36 };
35 37
36 #endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_ 38 #endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/chrome_history_client.cc ('k') | chrome/browser/history/chrome_history_client_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698