components/history/core/browser/history_client.cc - Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/history/core/browser/history_client.cc

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresss comments & rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/base/testing_profile.cc ('K') | « components/history/core/browser/history_client.h ('k') | components/history/core/test/history_client_fake_bookmarks.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/history/core/browser/history_client.h"

	6

	7 namespace history {

	8

	9 void HistoryClient::BlockUntilBookmarksLoaded() {

	10 }

	11

	12 bool HistoryClient::IsBookmarked(const GURL& url) {

	13 return false;

	14 }

	15

	16 void HistoryClient::GetBookmarks(std::vector<URLAndTitle>* bookmarks) {

	17 }

	18

	19 HistoryClient::HistoryClient() {

	20 }

	21

	22 }

OLD	NEW