Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: chrome/browser/history/history_service_factory.cc

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/history_service_factory.h" 5 #include "chrome/browser/history/history_service_factory.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/history/chrome_history_client.h" 9 #include "chrome/browser/history/chrome_history_client.h"
10 #include "chrome/browser/history/chrome_history_client_factory.h" 10 #include "chrome/browser/history/chrome_history_client_factory.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 // static 54 // static
55 void HistoryServiceFactory::ShutdownForProfile(Profile* profile) { 55 void HistoryServiceFactory::ShutdownForProfile(Profile* profile) {
56 HistoryServiceFactory* factory = GetInstance(); 56 HistoryServiceFactory* factory = GetInstance();
57 factory->BrowserContextDestroyed(profile); 57 factory->BrowserContextDestroyed(profile);
58 } 58 }
59 59
60 HistoryServiceFactory::HistoryServiceFactory() 60 HistoryServiceFactory::HistoryServiceFactory()
61 : BrowserContextKeyedServiceFactory( 61 : BrowserContextKeyedServiceFactory(
62 "HistoryService", BrowserContextDependencyManager::GetInstance()) { 62 "HistoryService", BrowserContextDependencyManager::GetInstance()) {
63 DependsOn(BookmarkModelFactory::GetInstance());
64 DependsOn(ChromeHistoryClientFactory::GetInstance()); 63 DependsOn(ChromeHistoryClientFactory::GetInstance());
65 } 64 }
66 65
67 HistoryServiceFactory::~HistoryServiceFactory() { 66 HistoryServiceFactory::~HistoryServiceFactory() {
68 } 67 }
69 68
70 KeyedService* HistoryServiceFactory::BuildServiceInstanceFor( 69 KeyedService* HistoryServiceFactory::BuildServiceInstanceFor(
71 content::BrowserContext* context) const { 70 content::BrowserContext* context) const {
72 Profile* profile = static_cast<Profile*>(context); 71 Profile* profile = static_cast<Profile*>(context);
73 HistoryService* history_service = new HistoryService( 72 HistoryService* history_service = new HistoryService(
74 ChromeHistoryClientFactory::GetForProfile(profile), profile); 73 ChromeHistoryClientFactory::GetForProfile(profile), profile);
75 if (!history_service->Init(profile->GetPath(), 74 if (!history_service->Init(profile->GetPath())) {
76 BookmarkModelFactory::GetForProfile(profile))) {
77 return NULL; 75 return NULL;
78 } 76 }
79 return history_service; 77 return history_service;
80 } 78 }
81 79
82 content::BrowserContext* HistoryServiceFactory::GetBrowserContextToUse( 80 content::BrowserContext* HistoryServiceFactory::GetBrowserContextToUse(
83 content::BrowserContext* context) const { 81 content::BrowserContext* context) const {
84 return chrome::GetBrowserContextRedirectedInIncognito(context); 82 return chrome::GetBrowserContextRedirectedInIncognito(context);
85 } 83 }
86 84
87 bool HistoryServiceFactory::ServiceIsNULLWhileTesting() const { 85 bool HistoryServiceFactory::ServiceIsNULLWhileTesting() const {
88 return true; 86 return true;
89 } 87 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698