Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/history/chrome_history_client_factory.cc

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/chrome_history_client_factory.h" 5 #include "chrome/browser/history/chrome_history_client_factory.h"
6 6
7 #include "base/memory/singleton.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
7 #include "chrome/browser/history/chrome_history_client.h" 9 #include "chrome/browser/history/chrome_history_client.h"
8 #include "chrome/browser/profiles/incognito_helpers.h" 10 #include "chrome/browser/profiles/incognito_helpers.h"
9 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
10 #include "components/keyed_service/content/browser_context_dependency_manager.h" 12 #include "components/keyed_service/content/browser_context_dependency_manager.h"
11 13
12 // static 14 // static
13 ChromeHistoryClient* ChromeHistoryClientFactory::GetForProfile( 15 ChromeHistoryClient* ChromeHistoryClientFactory::GetForProfile(
14 Profile* profile) { 16 Profile* profile) {
15 return static_cast<ChromeHistoryClient*>( 17 return static_cast<ChromeHistoryClient*>(
16 GetInstance()->GetServiceForBrowserContext(profile, true)); 18 GetInstance()->GetServiceForBrowserContext(profile, true));
17 } 19 }
18 20
19 // static 21 // static
20 ChromeHistoryClientFactory* ChromeHistoryClientFactory::GetInstance() { 22 ChromeHistoryClientFactory* ChromeHistoryClientFactory::GetInstance() {
21 return Singleton<ChromeHistoryClientFactory>::get(); 23 return Singleton<ChromeHistoryClientFactory>::get();
22 } 24 }
23 25
24 ChromeHistoryClientFactory::ChromeHistoryClientFactory() 26 ChromeHistoryClientFactory::ChromeHistoryClientFactory()
25 : BrowserContextKeyedServiceFactory( 27 : BrowserContextKeyedServiceFactory(
26 "ChromeHistoryClient", 28 "ChromeHistoryClient",
27 BrowserContextDependencyManager::GetInstance()) { 29 BrowserContextDependencyManager::GetInstance()) {
30 DependsOn(BookmarkModelFactory::GetInstance());
28 } 31 }
29 32
30 ChromeHistoryClientFactory::~ChromeHistoryClientFactory() { 33 ChromeHistoryClientFactory::~ChromeHistoryClientFactory() {
31 } 34 }
32 35
33 KeyedService* ChromeHistoryClientFactory::BuildServiceInstanceFor( 36 KeyedService* ChromeHistoryClientFactory::BuildServiceInstanceFor(
34 content::BrowserContext* context) const { 37 content::BrowserContext* context) const {
35 return new ChromeHistoryClient(); 38 return new ChromeHistoryClient(
39 BookmarkModelFactory::GetForProfile(static_cast<Profile*>(context)));
36 } 40 }
37 41
38 content::BrowserContext* ChromeHistoryClientFactory::GetBrowserContextToUse( 42 content::BrowserContext* ChromeHistoryClientFactory::GetBrowserContextToUse(
39 content::BrowserContext* context) const { 43 content::BrowserContext* context) const {
40 return chrome::GetBrowserContextRedirectedInIncognito(context); 44 return chrome::GetBrowserContextRedirectedInIncognito(context);
41 } 45 }
42 46
43 bool ChromeHistoryClientFactory::ServiceIsNULLWhileTesting() const { 47 bool ChromeHistoryClientFactory::ServiceIsNULLWhileTesting() const {
44 return true; 48 return true;
45 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698