Remove built-in pages that don't work on Android from suggest.

chrome/common/url_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/url_constants.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "content/public/common/url_constants.h"
@@ skipping 546 matching lines @@
 const char kNotificationWelcomeLearnMoreURL[] =
     "https://support.google.com/chrome/?p=ib_google_now_welcome";
 
 // Add hosts here to be included in chrome://chrome-urls (about:about).
 // These hosts will also be suggested by BuiltinProvider.
 const char* const kChromeHostURLs[] = {
   kChromeUICacheHost,
   kChromeUIChromeURLsHost,
   kChromeUIComponentsHost,
   kChromeUICrashesHost,
   kChromeUICreditsHost,

[Mark P, 2014/05/19 18:30:20]

This is an array.  Does reordering it change the order in which URLs appear in
about:about?  If so, I'd suggest reverting this part of this change.  (Being
alphabetized--regardless of platform--is handy.)

[Peter Kasting, 2014/05/19 18:50:11]

No.  about_ui.cc sorts the list itself.  Which is good, because trying to keep
this list ordered alphabetically by the values of these strings, instead of
their names, would be that much more confusing.

-#if defined(ENABLE_SERVICE_DISCOVERY)
-  kChromeUIDevicesHost,
-#endif
   kChromeUIDNSHost,
   kChromeUIFlagsHost,
-  kChromeUIGCMInternalsHost,
-  kChromeUIHelpHost,
   kChromeUIHistoryHost,
   kChromeUIInvalidationsHost,
-  kChromeUIIPCHost,
   kChromeUIMemoryHost,
   kChromeUIMemoryInternalsHost,
-#if defined(OS_ANDROID) || defined(OS_IOS)
-  kChromeUINetExportHost,
-#endif
   kChromeUINetInternalsHost,
   kChromeUINewTabHost,
   kChromeUIOmniboxHost,
   kChromeUIPredictorsHost,
   kChromeUIProfilerHost,
-  kChromeUIQuotaInternalsHost,
   kChromeUISignInInternalsHost,
   kChromeUIStatsHost,
   kChromeUISyncInternalsHost,
-  kChromeUISystemInfoHost,
   kChromeUITermsHost,
   kChromeUITranslateInternalsHost,
-  kChromeUIUberHost,
   kChromeUIUserActionsHost,
   kChromeUIVersionHost,
+  content::kChromeUIAccessibilityHost,
+  content::kChromeUIAppCacheInternalsHost,
+  content::kChromeUIBlobInternalsHost,
+  content::kChromeUIGpuHost,
+  content::kChromeUIHistogramHost,
+  content::kChromeUIIndexedDBInternalsHost,
+  content::kChromeUIMediaInternalsHost,
+  content::kChromeUINetworkViewCacheHost,
+  content::kChromeUIServiceWorkerInternalsHost,
+  content::kChromeUITracingHost,
+  content::kChromeUIWebRTCInternalsHost,
 #if defined(OS_ANDROID)
   kChromeUIWelcomeHost,
 #else
   kChromeUIAppLauncherPageHost,
   kChromeUIBookmarksHost,
   kChromeUIDownloadsHost,
   kChromeUIFlashHost,
+  kChromeUIGCMInternalsHost,
+  kChromeUIHelpHost,
   kChromeUIInspectHost,
+  kChromeUIIPCHost,
   kChromeUIPluginsHost,
+  kChromeUIQuotaInternalsHost,
   kChromeUISettingsHost,
+  kChromeUISystemInfoHost,
+  kChromeUIUberHost,
 #endif
-#if defined(OS_WIN)
-  kChromeUIConflictsHost,
-#endif
-#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
-  kChromeUILinuxProxyConfigHost,
-  kChromeUISandboxHost,
+#if defined(OS_ANDROID) || defined(OS_IOS)
+  kChromeUINetExportHost,
 #endif
 #if defined(OS_CHROMEOS)
   kChromeUICertificateManagerHost,
   kChromeUIChooseMobileNetworkHost,
   kChromeUICryptohomeHost,
   kChromeUIDiscardsHost,
   kChromeUIDriveInternalsHost,
   kChromeUIFirstRunHost,
   kChromeUIImageBurnerHost,
   kChromeUIKeyboardOverlayHost,
   kChromeUILoginHost,
   kChromeUINetworkHost,
   kChromeUIOobeHost,
   kChromeUIOSCreditsHost,
   kChromeUIPowerHost,
   kChromeUIProxySettingsHost,
   kChromeUITaskManagerHost,
 #endif
+#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
+  kChromeUILinuxProxyConfigHost,
+  kChromeUISandboxHost,
+#endif
+#if defined(OS_WIN)
+  kChromeUIConflictsHost,
+#endif
 #if !defined(DISABLE_NACL)
   kChromeUINaClHost,
 #endif
 #if defined(ENABLE_CONFIGURATION_POLICY)
   kChromeUIPolicyHost,
 #endif
 #if defined(ENABLE_EXTENSIONS)
   kChromeUIExtensionsHost,
 #endif
 #if defined(ENABLE_FULL_PRINTING)
   kChromeUIPrintHost,
 #endif
-  content::kChromeUIAccessibilityHost,
-  content::kChromeUIAppCacheInternalsHost,
-  content::kChromeUIBlobInternalsHost,
-  content::kChromeUIGpuHost,
-  content::kChromeUIHistogramHost,
-  content::kChromeUIIndexedDBInternalsHost,
-  content::kChromeUIMediaInternalsHost,
-  content::kChromeUINetworkViewCacheHost,
-  content::kChromeUIServiceWorkerInternalsHost,
-  content::kChromeUITracingHost,
-  content::kChromeUIWebRTCInternalsHost,
+#if defined(ENABLE_SERVICE_DISCOVERY)
+  kChromeUIDevicesHost,
+#endif
 #if defined(ENABLE_WEBRTC)
   kChromeUIWebRtcLogsHost,
 #endif
 };
 const size_t kNumberOfChromeHostURLs = arraysize(kChromeHostURLs);
 
 const char* const kChromeDebugURLs[] = {
   content::kChromeUICrashURL,
   content::kChromeUIKillURL,
   content::kChromeUIHangURL,
@@ skipping 44 matching lines @@
     "";
 #endif
 #endif
 
 // TODO(tengs): Replace with real URL when ready.
 const char kEasyUnlockLearnMoreUrl[] =
     "https://support.google.com/chromebook/?p=easy_unlock";
 const char kEasyUnlockManagementUrl[] = "https://chrome.com";
 
 }  // namespace chrome