Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: net/quic/quic_unacked_packet_map.h

Issue 285233006: Fix a QUIC bug where a packet could remain in the UnackedPacketMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_unacked_packet_map.h
diff --git a/net/quic/quic_unacked_packet_map.h b/net/quic/quic_unacked_packet_map.h
index 759bd7ba2c3328f7c9897121e93eb101709a92f0..65c15ddf7e609511113d46e50d17ed00af36cfda 100644
--- a/net/quic/quic_unacked_packet_map.h
+++ b/net/quic/quic_unacked_packet_map.h
@@ -122,8 +122,10 @@ class NET_EXPORT_PRIVATE QuicUnackedPacketMap {
// frames, and sets all_transmissions to only include itself.
void NeuterPacket(QuicPacketSequenceNumber sequence_number);
- // Returns true if the packet has been marked as sent by SetSent.
- static bool IsSentAndNotPending(const TransmissionInfo& transmission_info);
+ // Returns true if the packet's only purpose is to measure RTT. It must not
+ // be pending, have retransmittable frames, or be linked to transmissions
+ // with retransmittable frames.
+ static bool IsForRttOnly(const TransmissionInfo& transmission_info);
private:
void MaybeRemoveRetransmittableFrames(TransmissionInfo* transmission_info);
« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698