Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 285233006: Fix a QUIC bug where a packet could remain in the UnackedPacketMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index cffdd4d67edd5d67d6fce65a8f3939130cb7d0de..6dc30a5f9ff5f1a2170f42caa7c93b3b72b22b47 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -172,7 +172,7 @@ void QuicSentPacketManager::HandleAckForSentPackets(
if (IsAwaitingPacket(received_info, sequence_number)) {
// Remove any packets not being tracked by the send algorithm, allowing
// the high water mark to be raised if necessary.
- if (QuicUnackedPacketMap::IsSentAndNotPending(it->second)) {
+ if (QuicUnackedPacketMap::IsForRttOnly(it->second)) {
it = MarkPacketHandled(sequence_number, delta_largest_observed);
} else {
// Consider it multiple nacks when there is a gap between the missing
@@ -261,8 +261,6 @@ void QuicSentPacketManager::NeuterUnencryptedPackets() {
// they are not retransmitted or considered lost from a congestion control
// perspective.
pending_retransmissions_.erase(it->first);
- // TODO(ianswett): This may cause packets to linger forever in the
- // UnackedPacketMap.
unacked_packets_.NeuterPacket(it->first);
unacked_packets_.SetNotPending(it->first);
}
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698