add audio-buffer-size command line flag support to the input audio for all the platforms

add audio-buffer-size command line flag support to the input audio for all the platforms.

This is required to do some experiments with low buffer size for input audio.

BUG=363958
TEST=manual test with audio-buffer-size flag

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271673

[no longer working on chromium, 2014-05-15 14:08:26]

Hi Dale, could you please review this CL?

Thanks,
SX

[DaleCurtis, 2014-05-15 17:55:21]

All this works, but I wonder if we want to use the same flag for both input and
output.  I can't remember if CrOS is setting this for any boards.  +dgreid

[dgreid, 2014-05-15 18:07:13]

On 2014/05/15 17:55:21, DaleCurtis wrote:
> All this works, but I wonder if we want to use the same flag for both input
and
> output.  I can't remember if CrOS is setting this for any boards.  +dgreid

CrOS doesn't use this flag.

Setting the input and output to be the same might be a good idea, there isn't a
lot of test time with them being different, although it should work OK.

[no longer working on chromium, 2014-05-15 20:42:03]

Dale, I think it should be OK to use the same flag for both input and output.
Right now only webrtc and webauduio need duplex streams, and we want the same
buffer size for most of the test cases.

Dylan, I would like to use this flag to verify if we can use 128 samples as
buffer size on ChromeOS, and there is some website saying that it should be able
to change the chromeos file system to write mode and modify
opt/google/chrome/chrome-wrapper to inject the flag, do you know if that will
work?

[dgreid, 2014-05-15 20:59:25]

> Dylan, I would like to use this flag to verify if we can use 128 samples as
> buffer size on ChromeOS, and there is some website saying that it should be
able
> to change the chromeos file system to write mode and modify
> opt/google/chrome/chrome-wrapper to inject the flag, do you know if that will
> work?

I always add flags to /sbin/session_manager_setup.sh.  Which is pretty easy if
you are in dev mode but you'll have to disable rootfs verification

# make_dev_ssd.sh --remove_rootfs_verification


BTW it looks like there is some arbitrary limits imposed in audio_manager_cras
for output buffer size, they will need to be removed to get good end-to-end
latency.

[no longer working on chromium, 2014-05-19 12:51:53]

On 2014/05/15 20:59:25, dgreid wrote:
> > Dylan, I would like to use this flag to verify if we can use 128 samples as
> > buffer size on ChromeOS, and there is some website saying that it should be
> able
> > to change the chromeos file system to write mode and modify
> > opt/google/chrome/chrome-wrapper to inject the flag, do you know if that
will
> > work?
> 
> I always add flags to /sbin/session_manager_setup.sh.  Which is pretty easy if
> you are in dev mode but you'll have to disable rootfs verification
> 
> # make_dev_ssd.sh --remove_rootfs_verification
> 

Thanks, I will try it out after landing this patch.

> 
> BTW it looks like there is some arbitrary limits imposed in audio_manager_cras
> for output buffer size, they will need to be removed to get good end-to-end
> latency.

I guess you meant kMinimumOutputBufferSize and kMaximumOutputBufferSize, if so,
we will bypass the limits when audio-buffer-size flag is used.

Dale, could you please take another look? Thanks.

[DaleCurtis, 2014-05-19 17:35:44]

lgtm

[no longer working on chromium, 2014-05-19 19:30:31]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-05-19 19:31:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/285233005/20001

[commit-bot: I haz the power, 2014-05-19 21:29:51]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-19 22:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 22:20:00]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[no longer working on chromium, 2014-05-20 13:43:40]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-05-20 13:44:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/285233005/40001

[commit-bot: I haz the power, 2014-05-20 17:14:32]

Change committed as 271673