Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: media/audio/android/audio_android_unittest.cc

Issue 2852323004: [Audio] Mark AudioAndroidInputTest.StartInputStreamCallbacks* flaky (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/android/build_info.h" 9 #include "base/android/build_info.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 788
789 // Ensure that a default output stream can be opened and closed. 789 // Ensure that a default output stream can be opened and closed.
790 TEST_F(AudioAndroidOutputTest, OpenAndCloseOutputStream) { 790 TEST_F(AudioAndroidOutputTest, OpenAndCloseOutputStream) {
791 GetDefaultOutputStreamParametersOnAudioThread(); 791 GetDefaultOutputStreamParametersOnAudioThread();
792 MakeAudioOutputStreamOnAudioThread(audio_output_parameters()); 792 MakeAudioOutputStreamOnAudioThread(audio_output_parameters());
793 OpenAndCloseAudioOutputStreamOnAudioThread(); 793 OpenAndCloseAudioOutputStreamOnAudioThread();
794 } 794 }
795 795
796 // Start input streaming using default input parameters and ensure that the 796 // Start input streaming using default input parameters and ensure that the
797 // callback sequence is sane. 797 // callback sequence is sane.
798 TEST_P(AudioAndroidInputTest, StartInputStreamCallbacks) { 798 // Flaky, see crbug.com/683408.
799 TEST_P(AudioAndroidInputTest, DISABLED_StartInputStreamCallbacks) {
799 AudioParameters native_params = GetInputStreamParameters(); 800 AudioParameters native_params = GetInputStreamParameters();
800 StartInputStreamCallbacks(native_params); 801 StartInputStreamCallbacks(native_params);
801 } 802 }
802 803
803 // Start input streaming using non default input parameters and ensure that the 804 // Start input streaming using non default input parameters and ensure that the
804 // callback sequence is sane. The only change we make in this test is to select 805 // callback sequence is sane. The only change we make in this test is to select
805 // a 10ms buffer size instead of the default size. 806 // a 10ms buffer size instead of the default size.
806 TEST_P(AudioAndroidInputTest, StartInputStreamCallbacksNonDefaultParameters) { 807 // Flaky, see crbug.com/683408.
808 TEST_P(AudioAndroidInputTest,
809 DISABLED_StartInputStreamCallbacksNonDefaultParameters) {
807 AudioParameters params = GetInputStreamParameters(); 810 AudioParameters params = GetInputStreamParameters();
808 params.set_frames_per_buffer(params.sample_rate() / 100); 811 params.set_frames_per_buffer(params.sample_rate() / 100);
809 StartInputStreamCallbacks(params); 812 StartInputStreamCallbacks(params);
810 } 813 }
811 814
812 // Start output streaming using default output parameters and ensure that the 815 // Start output streaming using default output parameters and ensure that the
813 // callback sequence is sane. 816 // callback sequence is sane.
814 TEST_F(AudioAndroidOutputTest, StartOutputStreamCallbacks) { 817 TEST_F(AudioAndroidOutputTest, StartOutputStreamCallbacks) {
815 GetDefaultOutputStreamParametersOnAudioThread(); 818 GetDefaultOutputStreamParametersOnAudioThread();
816 StartOutputStreamCallbacks(audio_output_parameters()); 819 StartOutputStreamCallbacks(audio_output_parameters());
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 printf("\n"); 966 printf("\n");
964 StopAndCloseAudioOutputStreamOnAudioThread(); 967 StopAndCloseAudioOutputStreamOnAudioThread();
965 StopAndCloseAudioInputStreamOnAudioThread(); 968 StopAndCloseAudioInputStreamOnAudioThread();
966 } 969 }
967 970
968 INSTANTIATE_TEST_CASE_P(AudioAndroidInputTest, 971 INSTANTIATE_TEST_CASE_P(AudioAndroidInputTest,
969 AudioAndroidInputTest, 972 AudioAndroidInputTest,
970 testing::Bool()); 973 testing::Bool());
971 974
972 } // namespace media 975 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698