ui/views/controls/menu/menu_runner_impl_cocoa.mm - Issue 2852233002: Mac[Views]: Make native menus more responsive by pumping private runloop modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_impl_cocoa.mm

Issue 2852233002: Mac[Views]: Make native menus more responsive by pumping private runloop modes. (Closed)

Patch Set: respond to comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_runner_impl_cocoa.mm

diff --git a/ui/views/controls/menu/menu_runner_impl_cocoa.mm b/ui/views/controls/menu/menu_runner_impl_cocoa.mm

index 62a758fcbd5e2f1dd6ca05a1fa8028a0537a7044..02d6a95faedd333d822d5c28abb0ab1d9982a5e3 100644

--- a/ui/views/controls/menu/menu_runner_impl_cocoa.mm

+++ b/ui/views/controls/menu/menu_runner_impl_cocoa.mm

@@ -103,6 +103,7 @@ MenuRunnerImplCocoa::MenuRunnerImplCocoa(

on_menu_closed_callback_(on_menu_closed_callback) {

menu_controller_.reset(

[[MenuController alloc] initWithModel:menu useWithPopUpButtonCell:NO]);

+ [menu_controller_ setPostItemSelectedAsTask:YES];

}

bool MenuRunnerImplCocoa::IsRunning() const {

« no previous file with comments | « ui/base/cocoa/menu_controller_unittest.mm ('k') | no next file » | no next file with comments »