Mac[Views]: Make native menus more responsive by pumping private runloop modes.

base/message_loop/message_pump_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "base/message_loop/message_pump_mac.h"
 
 #import <Foundation/Foundation.h>
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/mac/call_with_eh_frame.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/macros.h"
 #include "base/message_loop/timer_slack.h"
 #include "base/run_loop.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 
 #if !defined(OS_IOS)
 #import <AppKit/AppKit.h>
 #endif  // !defined(OS_IOS)
 
 namespace base {
 
 namespace {
 
+// AppKit RunLoop modes observed to potentially run tasks posted to Chrome's
+// main thread task runner. Some are internal to AppKit but must be observed to
+// keep Chrome's UI responsive. Others that may be interesting, but are not
+// watched:
+//  - com.apple.hitoolbox.windows.transitionmode
+//  - com.apple.hitoolbox.windows.flushmode
+const CFStringRef kAllModes[] = {
+    kCFRunLoopCommonModes,
+
+    // Mode that only sees Chrome work sources.
+    kMessageLoopExclusiveRunLoopMode,
+
+    // Process work when NSMenus are fading out.
+    CFSTR("com.apple.hitoolbox.windows.windowfadingmode"),
+
+    // Process work when AppKit is highlighting an item on the main menubar.
+    CFSTR("NSUnhighlightMenuRunLoopMode"),
+};
+
 void CFRunLoopAddSourceToAllModes(CFRunLoopRef rl, CFRunLoopSourceRef source) {
-  CFRunLoopAddSource(rl, source, kCFRunLoopCommonModes);
-  CFRunLoopAddSource(rl, source, kMessageLoopExclusiveRunLoopMode);
+  for (const CFStringRef& mode : kAllModes)
+    CFRunLoopAddSource(rl, source, mode);
 }
 
 void CFRunLoopRemoveSourceFromAllModes(CFRunLoopRef rl,
                                        CFRunLoopSourceRef source) {
-  CFRunLoopRemoveSource(rl, source, kCFRunLoopCommonModes);
-  CFRunLoopRemoveSource(rl, source, kMessageLoopExclusiveRunLoopMode);
+  for (const CFStringRef& mode : kAllModes)
+    CFRunLoopRemoveSource(rl, source, mode);
 }
 
 void CFRunLoopAddTimerToAllModes(CFRunLoopRef rl, CFRunLoopTimerRef timer) {
-  CFRunLoopAddTimer(rl, timer, kCFRunLoopCommonModes);
-  CFRunLoopAddTimer(rl, timer, kMessageLoopExclusiveRunLoopMode);
+  for (const CFStringRef& mode : kAllModes)
+    CFRunLoopAddTimer(rl, timer, mode);
 }
 
 void CFRunLoopRemoveTimerFromAllModes(CFRunLoopRef rl,
                                       CFRunLoopTimerRef timer) {
-  CFRunLoopRemoveTimer(rl, timer, kCFRunLoopCommonModes);
-  CFRunLoopRemoveTimer(rl, timer, kMessageLoopExclusiveRunLoopMode);
+  for (const CFStringRef& mode : kAllModes)
+    CFRunLoopRemoveTimer(rl, timer, mode);
 }
 
 void CFRunLoopAddObserverToAllModes(CFRunLoopRef rl,
                                     CFRunLoopObserverRef observer) {
-  CFRunLoopAddObserver(rl, observer, kCFRunLoopCommonModes);
-  CFRunLoopAddObserver(rl, observer, kMessageLoopExclusiveRunLoopMode);
+  for (const CFStringRef& mode : kAllModes)
+    CFRunLoopAddObserver(rl, observer, mode);
 }
 
 void CFRunLoopRemoveObserverFromAllModes(CFRunLoopRef rl,
                                          CFRunLoopObserverRef observer) {
-  CFRunLoopRemoveObserver(rl, observer, kCFRunLoopCommonModes);
-  CFRunLoopRemoveObserver(rl, observer, kMessageLoopExclusiveRunLoopMode);
+  for (const CFStringRef& mode : kAllModes)
+    CFRunLoopRemoveObserver(rl, observer, mode);
 }
 
 void NoOp(void* info) {
 }
 
 const CFTimeInterval kCFTimeIntervalMax =
     std::numeric_limits<CFTimeInterval>::max();
 
 #if !defined(OS_IOS)
 // Set to true if MessagePumpMac::Create() is called before NSApp is
@@ skipping 804 matching lines @@
     [NSApplication sharedApplication];
     g_not_using_cr_app = true;
     return new MessagePumpNSApplication;
 #endif
   }
 
   return new MessagePumpNSRunLoop;
 }
 
 }  // namespace base