Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java

Issue 2852193003: Move second part of initialization tasks to ProcessInitializationHandler (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
index f5370f9faac0b13a295f99b73e520f2dd7fbdeb9..da9b5c71430d53507317473f94ca65faec56fbb5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
@@ -13,14 +13,10 @@ import android.os.MessageQueue;
import android.os.SystemClock;
import android.support.annotation.UiThread;
import android.support.annotation.WorkerThread;
-import android.view.inputmethod.InputMethodInfo;
-import android.view.inputmethod.InputMethodManager;
-import android.view.inputmethod.InputMethodSubtype;
import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.base.PowerMonitor;
-import org.chromium.base.SysUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
@@ -29,7 +25,6 @@ import org.chromium.chrome.browser.bookmarkswidget.BookmarkWidgetProvider;
import org.chromium.chrome.browser.crash.LogcatExtractionRunnable;
import org.chromium.chrome.browser.crash.MinidumpUploadService;
import org.chromium.chrome.browser.init.ProcessInitializationHandler;
-import org.chromium.chrome.browser.media.MediaCaptureNotificationService;
import org.chromium.chrome.browser.metrics.LaunchMetrics;
import org.chromium.chrome.browser.metrics.UmaUtils;
import org.chromium.chrome.browser.notifications.ChannelsUpdater;
@@ -45,15 +40,12 @@ import org.chromium.chrome.browser.webapps.ChromeWebApkHost;
import org.chromium.chrome.browser.webapps.WebApkVersionManager;
import org.chromium.chrome.browser.webapps.WebappRegistry;
import org.chromium.components.minidump_uploader.CrashFileManager;
-import org.chromium.content.browser.ChildProcessLauncher;
import java.io.File;
-import java.util.ArrayList;
import java.util.Arrays;
import java.util.Date;
import java.util.LinkedList;
import java.util.List;
-import java.util.Locale;
import java.util.Queue;
import java.util.concurrent.TimeUnit;
@@ -209,18 +201,6 @@ public class DeferredStartupHandler {
}
});
- mDeferredTasks.add(new Runnable() {
- @Override
- public void run() {
- // Clear any media notifications that existed when Chrome was last killed.
- MediaCaptureNotificationService.clearMediaNotifications(mAppContext);
-
- startModerateBindingManagementIfNeeded();
-
- recordKeyboardLocaleUma();
- }
- });
-
ProcessInitializationHandler.getInstance().initializeDeferredStartupTasks();
}
@@ -393,12 +373,6 @@ public class DeferredStartupHandler {
.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
}
- private void startModerateBindingManagementIfNeeded() {
- // Moderate binding doesn't apply to low end devices.
- if (SysUtils.isLowEndDevice()) return;
- ChildProcessLauncher.startModerateBindingManagement(mAppContext);
- }
-
/**
* Deletes the snapshot database which is no longer used because the feature has been removed
* in Chrome M41.
@@ -414,35 +388,6 @@ public class DeferredStartupHandler {
}
}
- @SuppressWarnings("deprecation") // InputMethodSubtype.getLocale() deprecated in API 24
- private void recordKeyboardLocaleUma() {
- InputMethodManager imm =
- (InputMethodManager) mAppContext.getSystemService(Context.INPUT_METHOD_SERVICE);
- List<InputMethodInfo> ims = imm.getEnabledInputMethodList();
- ArrayList<String> uniqueLanguages = new ArrayList<>();
- for (InputMethodInfo method : ims) {
- List<InputMethodSubtype> submethods =
- imm.getEnabledInputMethodSubtypeList(method, true);
- for (InputMethodSubtype submethod : submethods) {
- if (submethod.getMode().equals("keyboard")) {
- String language = submethod.getLocale().split("_")[0];
- if (!uniqueLanguages.contains(language)) {
- uniqueLanguages.add(language);
- }
- }
- }
- }
- RecordHistogram.recordCountHistogram("InputMethod.ActiveCount", uniqueLanguages.size());
-
- InputMethodSubtype currentSubtype = imm.getCurrentInputMethodSubtype();
- Locale systemLocale = Locale.getDefault();
- if (currentSubtype != null && currentSubtype.getLocale() != null && systemLocale != null) {
- String keyboardLanguage = currentSubtype.getLocale().split("_")[0];
- boolean match = systemLocale.getLanguage().equalsIgnoreCase(keyboardLanguage);
- RecordHistogram.recordBooleanHistogram("InputMethod.MatchesSystemLanguage", match);
- }
- }
-
/**
* @return Whether deferred startup has been completed.
*/
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698