Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2458)

Unified Diff: chrome/renderer/plugins/plugin_uma.h

Issue 2852193002: PDF: Add UMA to track successful / failed PDF loads (Closed)
Patch Set: fix up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/plugin_uma.h
diff --git a/chrome/renderer/plugins/plugin_uma.h b/chrome/renderer/plugins/plugin_uma.h
index b29e9dc31c641f59bfaa375bd541440ae03d8582..21d209bc7976cd7a275a88a3dc2fcb9027df845d 100644
--- a/chrome/renderer/plugins/plugin_uma.h
+++ b/chrome/renderer/plugins/plugin_uma.h
@@ -22,7 +22,7 @@ class PluginUMAReporter {
public:
enum ReportType {
MISSING_PLUGIN,
- DISABLED_PLUGIN
+ DISABLED_PLUGIN,
};
// Make sure the enum list in tools/histogram/histograms.xml is updated with
@@ -44,6 +44,14 @@ class PluginUMAReporter {
PLUGIN_TYPE_MAX
};
+ // Must be kept in sync with PDFLoadStatus enum in histograms.xml.
+ enum PDFLoadStatus {
+ LOADED_FULL_PAGE_PDF_WITH_PDFIUM = 0,
+ LOADED_EMBEDDED_PDF_WITH_PDFIUM = 1,
+ SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF = 2,
+ PDF_LOAD_STATUS_MAX
+ };
+
// Sends UMA data, i.e. plugin's type.
class UMASender {
public:
@@ -55,6 +63,8 @@ class PluginUMAReporter {
// Returns singleton instance.
static PluginUMAReporter* GetInstance();
+ static void ReportPDFLoadStatus(PDFLoadStatus status);
+
void ReportPluginMissing(const std::string& plugin_mime_type,
const GURL& plugin_src);

Powered by Google App Engine
This is Rietveld 408576698