PDF: Add UMA to track successful / failed PDF loads

chrome/renderer/plugins/plugin_uma.h

Index: chrome/renderer/plugins/plugin_uma.h
diff --git a/chrome/renderer/plugins/plugin_uma.h b/chrome/renderer/plugins/plugin_uma.h
index b29e9dc31c641f59bfaa375bd541440ae03d8582..dc0444841bed6f0b40b517b62029c4dde287a1da 100644
--- a/chrome/renderer/plugins/plugin_uma.h
+++ b/chrome/renderer/plugins/plugin_uma.h
@@ -22,7 +22,7 @@ class PluginUMAReporter {
  public:
   enum ReportType {
     MISSING_PLUGIN,
-    DISABLED_PLUGIN
+    DISABLED_PLUGIN,
   };
 
   // Make sure the enum list in tools/histogram/histograms.xml is updated with
@@ -44,6 +44,14 @@ class PluginUMAReporter {
     PLUGIN_TYPE_MAX
   };
 
+  // Must be kept in sync with PDFLoadStatus enum in histograms.xml.
+  enum PDFLoadStatus {
+    LOADED_FULL_PAGE_PDF_WITH_PDFIUM = 0,
+    LOADED_EMBEDDED_PDF_WITH_PDFIUM = 1,
+    SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF = 2,
+    PDF_LOAD_STATUS_MAX
+  };
+
   // Sends UMA data, i.e. plugin's type.
   class UMASender {
    public:
@@ -61,6 +69,8 @@ class PluginUMAReporter {
   void ReportPluginDisabled(const std::string& plugin_mime_type,
                             const GURL& plugin_src);
 
+  static void ReportPDFLoadStatus(PDFLoadStatus status);

[Lei Zhang, 2017/05/03 23:50:34]

Keep the static methods together.

[tommycli, 2017/05/04 00:08:31]

Done.

+
  private:
   friend struct base::DefaultSingletonTraits<PluginUMAReporter>;
   friend class PluginUMATest;