PDF: Add UMA to track successful / failed PDF loads

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/common/channel_info.h"
+#include "chrome/common/chrome_content_client.h"

[Lei Zhang, 2017/05/03 23:50:34]

Remove existing entry from line 158 then?

[tommycli, 2017/05/04 00:08:30]

Done.

 #include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_isolated_world_ids.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pause_tabs_field_trial.h"
 #include "chrome/common/pepper_permission_util.h"
 #include "chrome/common/prerender_types.h"
 #include "chrome/common/render_messages.h"
@@ skipping 78 matching lines @@
 #include "third_party/WebKit/public/platform/WebURLError.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/platform/WebURLResponse.h"
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPluginContainer.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
+#include "third_party/WebKit/public/web/WebView.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/layout.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/webui/jstemplate_builder.h"
 #include "url/origin.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/renderer/sandbox_status_extension_android.h"
 #endif
 
@@ skipping 672 matching lines @@
 #if defined(OS_CHROMEOS)
                 l10n_util::GetStringUTF16(IDS_NACL_PLUGIN_BLOCKED));
 #else
                 l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED, group_name));
 #endif
             break;
           }
         }
 #endif  // !defined(DISABLE_NACL) && BUILDFLAG(ENABLE_EXTENSIONS)
 
+        // Report PDF load metrics. Since the PDF plugin is comprised of an
+        // extension that loads another plugin, make sure we don't double count.

[Lei Zhang, 2017/05/03 23:50:34]

extension that loads a second plugin, avoid double counting by ignoring the
creation of the second plugin.

[tommycli, 2017/05/04 00:08:30]

Done.

+        if (info.name == ASCIIToUTF16(ChromeContentClient::kPDFPluginName) &&
+            GURL(frame->GetDocument().Url()).host_piece() !=
+                extension_misc::kPdfExtensionId) {
+          bool is_main_frame_plugin_document =
+              frame->View()->MainFrame()->IsWebLocalFrame() &&

[Lei Zhang, 2017/05/03 23:50:34]

I think the following does the same, without having to involve WebView.

render_frame->IsMainFrame() &&
render_frame->GetWebFrame()->GetDocument().IsPluginDocument()

[tommycli, 2017/05/04 00:08:31]

Done.

+              frame->View()->MainFrame()->GetDocument().IsPluginDocument();
+          PluginUMAReporter::ReportPDFLoadStatus(
+              is_main_frame_plugin_document
+                  ? PluginUMAReporter::LOADED_FULL_PAGE_PDF_WITH_PDFIUM
+                  : PluginUMAReporter::LOADED_EMBEDDED_PDF_WITH_PDFIUM);
+        }
+
         // Delay loading plugins if prerendering.
         // TODO(mmenke):  In the case of prerendering, feed into
         //                ChromeContentRendererClient::CreatePlugin instead, to
         //                reduce the chance of future regressions.
         bool is_prerendering =
             prerender::PrerenderHelper::IsPrerendering(render_frame);
 
         bool power_saver_setting_on =
             status ==
             ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent;
@@ skipping 20 matching lines @@
           placeholder->AllowLoading();
           break;
         }
 
         // Same-origin and whitelisted-origin plugins skip the placeholder.
         return render_frame->CreatePlugin(frame, info, params, nullptr);
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kDisabled: {
         PluginUMAReporter::GetInstance()->ReportPluginDisabled(orig_mime_type,
                                                                url);
+        if (info.name == ASCIIToUTF16(ChromeContentClient::kPDFPluginName)) {
+          PluginUMAReporter::ReportPDFLoadStatus(
+              PluginUMAReporter::
+                  SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF);
+        }
+
         placeholder = create_blocked_plugin(
             IDR_DISABLED_PLUGIN_HTML,
             l10n_util::GetStringFUTF16(IDS_PLUGIN_DISABLED, group_name));
         break;
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kFlashHiddenPreferHtml: {
         placeholder = create_blocked_plugin(
             IDR_PREFER_HTML_PLUGIN_HTML,
             l10n_util::GetStringFUTF16(IDS_PLUGIN_PREFER_HTML_BY_DEFAULT,
                                        group_name));
@@ skipping 687 matching lines @@
 
   RecordYouTubeRewriteUMA(result);
   return corrected_url.ReplaceComponents(r);
 }
 
 std::unique_ptr<base::TaskScheduler::InitParams>
 ChromeContentRendererClient::GetTaskSchedulerInitParams() {
   return task_scheduler_util::
       GetRendererTaskSchedulerInitParamsFromCommandLine();
 }