third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js - Issue 2852173002: DevTools: Show screenshots on the main flamechart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2852173002: DevTools: Show screenshots on the main flamechart (Closed)

Patch Set: addressing comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

index 81d5220e53f474a5e1f75c9ccf647664306180f5..881917cff72caf61151232489b30fe92a47fdc40 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

@@ -30,6 +30,8 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {

var mainViewGroupExpansionSetting = Common.settings.createSetting('timelineFlamechartMainViewGroupExpansion', {});

this._mainDataProvider = new Timeline.TimelineFlameChartDataProvider(filters);

+ this._mainDataProvider.addEventListener(

+ Timeline.TimelineFlameChartDataProvider.Events.DataChanged, () => this._mainFlameChart.scheduleUpdate());

this._mainFlameChart = new PerfUI.FlameChart(this._mainDataProvider, this, mainViewGroupExpansionSetting);

this._mainFlameChart.alwaysShowVerticalScroll();

this._mainFlameChart.enableRuler(false);