third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js - Issue 2852173002: DevTools: Show screenshots on the main flamechart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

Issue 2852173002: DevTools: Show screenshots on the main flamechart (Closed)

Patch Set: addressing comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

index edd10a8cceb4f37a6a8101a5598ec37ddb17fd6b..52742a12d7775717c7f5fbd30acfb34bb2f33cad 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

@@ -122,12 +122,7 @@ Timeline.TimelineDetailsView = class extends UI.VBox {

break;

case Timeline.TimelineSelection.Type.Frame:

var frame = /** @type {!TimelineModel.TimelineFrame} */ (this._selection.object());

- var screenshotTime = frame.idle ?

- frame.startTime :

- frame.endTime; // For idle frames, look at the state at the beginning of the frame.

- var filmStripFrame = this._model.filmStripModel().frameByTimestamp(screenshotTime);

- if (filmStripFrame && filmStripFrame.timestamp - frame.endTime > 10)

- filmStripFrame = null;

+ var filmStripFrame = this._model.filmStripModelFrame(frame);

this._setContent(Timeline.TimelineUIUtils.generateDetailsContentForFrame(frame, filmStripFrame));

if (frame.layerTree) {

var layersView = this._layersView();