Source/core/dom/Document.h - Issue 285213003: Oilpan: move Node traversal objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.h

Issue 285213003: Oilpan: move Node traversal objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add virtual to NodeIteratorBase::trace Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.h

diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h

index df3609baa3a18d8ebc9a03b3aea35c4c3a264bb3..0d8443abd706d6d8827095f8c62d0f4669d495f7 100644

--- a/Source/core/dom/Document.h

+++ b/Source/core/dom/Document.h

@@ -478,13 +478,13 @@ public:

PassRefPtrWillBeRawPtr<Range> createRange();

- PassRefPtr<NodeIterator> createNodeIterator(Node* root, ExceptionState&);

- PassRefPtr<NodeIterator> createNodeIterator(Node* root, unsigned whatToShow, ExceptionState&);

- PassRefPtr<NodeIterator> createNodeIterator(Node* root, unsigned whatToShow, PassRefPtr<NodeFilter>, ExceptionState&);

+ PassRefPtrWillBeRawPtr<NodeIterator> createNodeIterator(Node* root, ExceptionState&);

+ PassRefPtrWillBeRawPtr<NodeIterator> createNodeIterator(Node* root, unsigned whatToShow, ExceptionState&);

+ PassRefPtrWillBeRawPtr<NodeIterator> createNodeIterator(Node* root, unsigned whatToShow, PassRefPtrWillBeRawPtr<NodeFilter>, ExceptionState&);

- PassRefPtr<TreeWalker> createTreeWalker(Node* root, ExceptionState&);

- PassRefPtr<TreeWalker> createTreeWalker(Node* root, unsigned whatToShow, ExceptionState&);

- PassRefPtr<TreeWalker> createTreeWalker(Node* root, unsigned whatToShow, PassRefPtr<NodeFilter>, ExceptionState&);

+ PassRefPtrWillBeRawPtr<TreeWalker> createTreeWalker(Node* root, ExceptionState&);

+ PassRefPtrWillBeRawPtr<TreeWalker> createTreeWalker(Node* root, unsigned whatToShow, ExceptionState&);

+ PassRefPtrWillBeRawPtr<TreeWalker> createTreeWalker(Node* root, unsigned whatToShow, PassRefPtrWillBeRawPtr<NodeFilter>, ExceptionState&);

// Special support for editing

PassRefPtrWillBeRawPtr<Text> createEditingTextNode(const String&);

@@ -1241,7 +1241,7 @@ private:

uint64_t m_domTreeVersion;

static uint64_t s_globalTreeVersion;

- HashSet<NodeIterator*> m_nodeIterators;

+ WillBeHeapHashSet<RawPtrWillBeWeakMember<NodeIterator> > m_nodeIterators;

HashSet<Range*> m_ranges;

unsigned short m_listenerTypes;