Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: Source/core/dom/NodeIterator.h

Issue 285213003: Oilpan: move Node traversal objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add virtual to NodeIteratorBase::trace Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no) 3 * Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
4 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 4 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
5 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 10 matching lines...) Expand all
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 * 22 *
23 */ 23 */
24 24
25 #ifndef NodeIterator_h 25 #ifndef NodeIterator_h
26 #define NodeIterator_h 26 #define NodeIterator_h
27 27
28 #include "bindings/v8/ScriptWrappable.h" 28 #include "bindings/v8/ScriptWrappable.h"
29 #include "core/dom/NodeFilter.h" 29 #include "core/dom/NodeFilter.h"
30 #include "core/dom/NodeIteratorBase.h" 30 #include "core/dom/NodeIteratorBase.h"
31 #include "platform/heap/Handle.h"
31 #include "wtf/PassRefPtr.h" 32 #include "wtf/PassRefPtr.h"
32 #include "wtf/RefCounted.h" 33 #include "wtf/RefCounted.h"
33 34
34 namespace WebCore { 35 namespace WebCore {
35 36
36 class ExceptionState; 37 class ExceptionState;
37 38
38 class NodeIterator : public ScriptWrappable, public RefCounted<NodeIterator>, pu blic NodeIteratorBase { 39 class NodeIterator FINAL : public RefCountedWillBeGarbageCollectedFinalized<Node Iterator>, public ScriptWrappable, public NodeIteratorBase {
40 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NodeIterator);
39 public: 41 public:
40 static PassRefPtr<NodeIterator> create(PassRefPtr<Node> rootNode, unsigned w hatToShow, PassRefPtr<NodeFilter> filter) 42 static PassRefPtrWillBeRawPtr<NodeIterator> create(PassRefPtrWillBeRawPtr<No de> rootNode, unsigned whatToShow, PassRefPtrWillBeRawPtr<NodeFilter> filter)
41 { 43 {
42 return adoptRef(new NodeIterator(rootNode, whatToShow, filter)); 44 return adoptRefWillBeNoop(new NodeIterator(rootNode, whatToShow, filter) );
43 } 45 }
44 ~NodeIterator();
45 46
46 PassRefPtr<Node> nextNode(ExceptionState&); 47 #if !ENABLE(OILPAN)
47 PassRefPtr<Node> previousNode(ExceptionState&); 48 virtual ~NodeIterator();
49 #endif
50
51 PassRefPtrWillBeRawPtr<Node> nextNode(ExceptionState&);
52 PassRefPtrWillBeRawPtr<Node> previousNode(ExceptionState&);
48 void detach(); 53 void detach();
49 54
50 Node* referenceNode() const { return m_referenceNode.node.get(); } 55 Node* referenceNode() const { return m_referenceNode.node.get(); }
51 bool pointerBeforeReferenceNode() const { return m_referenceNode.isPointerBe foreNode; } 56 bool pointerBeforeReferenceNode() const { return m_referenceNode.isPointerBe foreNode; }
52 57
53 // This function is called before any node is removed from the document tree . 58 // This function is called before any node is removed from the document tree .
54 void nodeWillBeRemoved(Node&); 59 void nodeWillBeRemoved(Node&);
55 60
61 virtual void trace(Visitor*) OVERRIDE;
62
56 private: 63 private:
57 NodeIterator(PassRefPtr<Node>, unsigned whatToShow, PassRefPtr<NodeFilter>); 64 NodeIterator(PassRefPtrWillBeRawPtr<Node>, unsigned whatToShow, PassRefPtrWi llBeRawPtr<NodeFilter>);
58 65
59 struct NodePointer { 66 class NodePointer {
60 RefPtr<Node> node; 67 DISALLOW_ALLOCATION();
61 bool isPointerBeforeNode; 68 public:
62 NodePointer(); 69 NodePointer();
63 NodePointer(PassRefPtr<Node>, bool); 70 NodePointer(PassRefPtrWillBeRawPtr<Node>, bool);
71
64 void clear(); 72 void clear();
65 bool moveToNext(Node* root); 73 bool moveToNext(Node* root);
66 bool moveToPrevious(Node* root); 74 bool moveToPrevious(Node* root);
75
76 RefPtrWillBeMember<Node> node;
77 bool isPointerBeforeNode;
78
79 void trace(Visitor* visitor)
80 {
81 visitor->trace(node);
82 }
67 }; 83 };
68 84
69 void updateForNodeRemoval(Node& nodeToBeRemoved, NodePointer&) const; 85 void updateForNodeRemoval(Node& nodeToBeRemoved, NodePointer&) const;
70 86
71 NodePointer m_referenceNode; 87 NodePointer m_referenceNode;
72 NodePointer m_candidateNode; 88 NodePointer m_candidateNode;
73 }; 89 };
74 90
75 } // namespace WebCore 91 } // namespace WebCore
76 92
77 #endif // NodeIterator_h 93 #endif // NodeIterator_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698