Complete declarations; detect invalid blocks

Complete declarations; detect invalid blocks

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/28b771019083f9b7434919943d357d38f14bbaf7

[messick, 2017-05-01 15:07:17]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2017-05-01 15:28:32]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-05-01 15:28:32]

lgtm

https://codereview.chromium.org/2852073002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
(right):

https://codereview.chromium.org/2852073002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart:306:
}
Perhaps add a test where there are other clauses, such as

class Sample extends Object

https://codereview.chromium.org/2852073002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart:519:
// TODO(messick) This should insert a newline and move the cursor there.
Consider updating the expectations as appropriate and using "@failingTest" to
mark the test as being expected to fail.

[scheglov, 2017-05-01 15:33:17]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-01 15:33:17]

LGTM

[messick, 2017-05-01 15:42:47]

In addition to completing (some) declarations these changes also enable
completions for code similar to:

  if <caret>
  return;

changing to

  if () {
    
  }
  return;

[messick, 2017-05-01 15:45:00]

Thanks for the reviews! I'll make the suggested changes in the next CL.

https://codereview.chromium.org/2852073002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
(right):

https://codereview.chromium.org/2852073002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart:306:
}
On 2017/05/01 15:28:32, Brian Wilkerson wrote:
> Perhaps add a test where there are other clauses, such as
> 
> class Sample extends Object

Acknowledged.

https://codereview.chromium.org/2852073002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart:519:
// TODO(messick) This should insert a newline and move the cursor there.
On 2017/05/01 15:28:32, Brian Wilkerson wrote:
> Consider updating the expectations as appropriate and using "@failingTest" to
> mark the test as being expected to fail.

Acknowledged.

[messick, 2017-05-01 15:45:50]

Description was changed from

==========
Complete declarations; detect invalid blocks
==========

to

==========
Complete declarations; detect invalid blocks

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/28b771019083f9b7434919943d357d38f14bbaf7
==========

[messick, 2017-05-01 15:45:55]

Committed patchset #1 (id:1) manually as
28b771019083f9b7434919943d357d38f14bbaf7 (presubmit successful).