Issue 2852053003: Fix typing in dart2js serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2852053003: Fix typing in dart2js serialization. (Closed)

Created:
3 years, 7 months ago by floitsch

Modified:
3 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	pkg/compiler/lib/src/serialization/serialization.dart	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

floitsch

Currently, `getObjectPropertyValue` always returns `String`. We could thus also require the actual map type to ...

3 years, 7 months ago (2017-05-01 14:58:12 UTC) #2

floitsch

3 years, 7 months ago (2017-05-02 11:27:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0367d955fbbac34f1d91a1ab1a2ef845a7800a8a (presubmit successful).