Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2852053002: Update documentation on trignometric functions. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update fingerprints. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -42 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/lib/math_patch.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/math_patch.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/math/math.dart View 7 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-01 08:12:54 UTC) #3
floitsch
LGTM.
3 years, 7 months ago (2017-05-01 12:50:55 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 40220ec0766bb2b179d3623d3f298223df842279 (presubmit successful).
3 years, 7 months ago (2017-05-01 13:00:32 UTC) #6
Lasse Reichstein Nielsen
ptal
3 years, 7 months ago (2017-05-02 12:04:50 UTC) #7
floitsch
LGTM. (I reopened this CL).
3 years, 7 months ago (2017-05-02 12:25:23 UTC) #9
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-03 07:49:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7998f590b1764b4849784d7a9dc33825c0dd3e1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698