Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/about_flags.cc

Issue 2852043002: Add a flag to enable Translate Compact Infobar on Android. (Closed)
Patch Set: fix LoginCustomFlags Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 333dbe006df7462a243584b050ea2da6b0e7465c..e989f9fb619a6be4e055b25352fe9f4d4ea957c2 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -68,6 +68,7 @@
#include "components/strings/grit/components_strings.h"
#include "components/sync/driver/sync_driver_switches.h"
#include "components/tracing/common/tracing_switches.h"
+#include "components/translate/core/browser/translate_infobar_delegate.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_prefs.h"
#include "components/version_info/version_info.h"
@@ -1585,6 +1586,11 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kPullToRefreshEffectDescription, kOsAndroid,
SINGLE_DISABLE_VALUE_TYPE(switches::kDisablePullToRefreshEffect)},
#endif // OS_ANDROID
+#if defined(OS_ANDROID)
gone 2017/05/04 01:37:07 can you just combine this OS_ANDROID block with th
Leo 2017/05/05 02:27:54 Done.
+ {"translate-compact-infobar", flag_descriptions::kTranslateCompactUIName,
+ flag_descriptions::kTranslateCompactUIDescription, kOsAndroid,
+ FEATURE_VALUE_TYPE(translate::kTranslateCompactUI)},
+#endif // OS_ANDROID
#if defined(OS_MACOSX)
{"enable-translate-new-ux", flag_descriptions::kTranslateNewUxName,
flag_descriptions::kTranslateNewUxDescription, kOsMac,
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698