Issue 2852012: Remove the dependency from renderer on browser.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2852012: Remove the dependency from renderer on browser. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years ago

Reviewers:
jeremy

CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Remove the dependency from renderer on browser. BUG=46666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50081

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	chrome/renderer/DEPS	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/renderer/render_process_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Trybot results: linux win mac

Total messages: 2 (0 generated)

Lei Zhang

Looks like someone did all the work except remove the header?

4 years, 11 months ago (2010-06-17 06:22:06 UTC) #1

rubberstamp LGTM