ios/chrome/browser/web/mailto_handler_system_mail.h - Issue 2852003002: Adds mailto: URL support to app launching.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/web/mailto_handler_system_mail.h

Issue 2852003002: Adds mailto: URL support to app launching. (Closed)

Patch Set: fixed lack of persistency of setDefaultHandlerID: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef _IOS_CHROME_BROWSER_WEB_MAILTO_HANDLER_SYSTEM_MAIL_H_

	6 #define _IOS_CHROME_BROWSER_WEB_MAILTO_HANDLER_SYSTEM_MAIL_H_

	7

	8 #import "ios/chrome/browser/web/mailto_handler.h"

	9

	10 // Handler for Apple Mail client.

	11 @interface MailtoHandlerSystemMail : MailtoHandler
	rohitrao (ping after 24h) 2017/05/06 00:09:41 Why do we maintain a handler for apple mail? Won' Why do we maintain a handler for apple mail? Won't the system default to apple mail if we leave the URL untouched? pkl (ping after 24h if needed) 2017/05/08 17:07:55 In theory, we should be able to leave the URL alon Show quoted text On 2017/05/06 00:09:41, rohitrao (ping after 24h) wrote: > Why do we maintain a handler for apple mail? Won't the system default to apple > mail if we leave the URL untouched? In theory, we should be able to leave the URL alone. But treating system Mail in the same way as 3rd party mail clients eliminates the need to special case the UI implementation of in Settings (coming up next) for system-provided Mail. It is "just one of the mail clients".
	12 @end

	13

	14 #endif // _IOS_CHROME_BROWSER_WEB_MAILTO_HANDLER_SYSTEM_MAIL_H_

OLD	NEW