Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 285193009: Let test driver export json results. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Let test driver export json results. BUG=374134 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21358

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Make option name uniform with the corresponding option in other chromium test drivers. #

Patch Set 4 : Review. #

Total comments: 1

Patch Set 5 : Unified test name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M tools/run-tests.py View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M tools/testrunner/local/progress.py View 1 2 3 4 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
PTAL
6 years, 7 months ago (2014-05-16 09:49:39 UTC) #1
Jakob Kummerow
As discussed offline, a cleaner approach would be to implement dumping results to a JSON ...
6 years, 7 months ago (2014-05-16 14:48:34 UTC) #2
Michael Achenbach
PTAL at patch 4.
6 years, 7 months ago (2014-05-16 15:12:44 UTC) #3
Jakob Kummerow
LGTM, this is much better. One comment. https://codereview.chromium.org/285193009/diff/80001/tools/testrunner/local/progress.py File tools/testrunner/local/progress.py (right): https://codereview.chromium.org/285193009/diff/80001/tools/testrunner/local/progress.py#newcode324 tools/testrunner/local/progress.py:324: "suite": test.suite.name, ...
6 years, 7 months ago (2014-05-16 15:28:33 UTC) #4
Michael Achenbach
On 2014/05/16 15:28:33, Jakob wrote: > LGTM, this is much better. One comment. > > ...
6 years, 7 months ago (2014-05-16 17:54:08 UTC) #5
Michael Achenbach
6 years, 7 months ago (2014-05-19 08:37:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r21358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698