[DevTools] Do not expose agents on Target

third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 49 matching lines @@
    * @param {string} domain
    */
   _addAgentGetterMethodToProtocolTargetPrototype(domain) {
     var upperCaseLength = 0;
     while (upperCaseLength < domain.length && domain[upperCaseLength].toLowerCase() !== domain[upperCaseLength])
       ++upperCaseLength;
 
     var methodName = domain.substr(0, upperCaseLength).toLowerCase() + domain.slice(upperCaseLength) + 'Agent';
 
     /**
-     * @this {Protocol.TargetBase}
+     * @this {Protocol.Dispatcher}
      */
     function agentGetter() {
       return this._agents[domain];
     }
 
-    Protocol.TargetBase.prototype[methodName] = agentGetter;
+    Protocol.Dispatcher.prototype[methodName] = agentGetter;
 
     /**
-     * @this {Protocol.TargetBase}
+     * @this {Protocol.Dispatcher}
      */
     function registerDispatcher(dispatcher) {
-      this.registerDispatcher(domain, dispatcher);
+      this._registerDispatcher(domain, dispatcher);
     }
 
-    Protocol.TargetBase.prototype['register' + domain + 'Dispatcher'] = registerDispatcher;
+    Protocol.Dispatcher.prototype['register' + domain + 'Dispatcher'] = registerDispatcher;
   }
 
   /**
    * @param {string} domain
    * @return {!Protocol.InspectorBackend._AgentPrototype}
    */
   _agentPrototype(domain) {
     if (!this._agentPrototypes[domain]) {
       this._agentPrototypes[domain] = new Protocol.InspectorBackend._AgentPrototype(domain);
       this._addAgentGetterMethodToProtocolTargetPrototype(domain);
@@ skipping 109 matching lines @@
 Protocol.InspectorBackend.Connection.Params;
 
 /**
  * @typedef {function(!Protocol.InspectorBackend.Connection.Params):!Protocol.InspectorBackend.Connection}
  */
 Protocol.InspectorBackend.Connection.Factory;
 
 /**
  * @unrestricted
  */
-Protocol.TargetBase = class {
+Protocol.Dispatcher = class {
   /**
    *  @param {!Protocol.InspectorBackend.Connection.Factory} connectionFactory
    */
   constructor(connectionFactory) {
     this._connection =
         connectionFactory({onMessage: this._onMessage.bind(this), onDisconnect: this._onDisconnect.bind(this)});
     this._lastMessageId = 1;
     this._pendingResponsesCount = 0;
     this._agents = {};
     this._dispatchers = {};
@@ skipping 143 matching lines @@
       }
 
       this._dispatchers[domainName].dispatch(method[1], messageObject);
     }
   }
 
   /**
    * @param {string} domain
    * @param {!Object} dispatcher
    */
-  registerDispatcher(domain, dispatcher) {
+  _registerDispatcher(domain, dispatcher) {
     if (!this._dispatchers[domain])
       return;
 
     this._dispatchers[domain].addDomainDispatcher(dispatcher);
   }
 
   /**
    * @param {function()=} script
    */
   _deprecatedRunAfterPendingDispatches(script) {
@@ skipping 27 matching lines @@
   _dumpProtocolMessage(message) {
     console.log(message);  // eslint-disable-line no-console
   }
 
   /**
    * @param {string} reason
    */
   _onDisconnect(reason) {
     this._connection = null;
     this._runPendingCallbacks();
-    this.dispose();
+    if (this._disposeCallback)

[caseq, 2017/04/29 02:12:53]

Rename to _disconnectCallback.

+      this._disposeCallback.call(null);
   }
 
   /**
-   * @protected
+   * @param {function()} callback
    */
-  dispose() {
+  setDisposeCallback(callback) {
+    this._disposeCallback = callback;
   }
 
   /**
    * @return {boolean}
    */
   isDisposed() {
     return !this._connection;
   }
 
   _runPendingCallbacks() {
@@ skipping 33 matching lines @@
   /**
    * @param {string} domain
    */
   constructor(domain) {
     this._replyArgs = {};
     this._hasErrorData = {};
     this._domain = domain;
   }
 
   /**
-   * @param {!Protocol.TargetBase} target
+   * @param {!Protocol.Dispatcher} target

[caseq, 2017/04/29 02:12:53]

This is confusing. Should this be renamed?

    */
   setTarget(target) {
     this._target = target;
   }
 
   /**
    * @param {string} methodName
    * @param {!Array.<!Object>} signature
    * @param {!Array.<string>} replyArgs
    * @param {boolean} hasErrorData
@@ skipping 231 matching lines @@
     if (Protocol.InspectorBackend.Options.dumpInspectorTimeStats)
       console.timeEnd(timingLabel);
   }
 };
 
 Protocol.InspectorBackend.Options = {
   dumpInspectorTimeStats: false,
   dumpInspectorProtocolMessages: false,
   suppressRequestErrors: false
 };