[Payments] Record CanMakePayment metrics on Desktop.

components/payments/core/journey_logger.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/core/journey_logger.h"
 
 #include <algorithm>
 
 #include "base/metrics/histogram_functions.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 55 matching lines @@
 
 JourneyLogger::JourneyLogger(bool is_incognito,
                              const GURL& url,
                              ukm::UkmService* ukm_service)
     : was_can_make_payments_used_(false),
       could_make_payment_(false),
       was_show_called_(false),
       is_incognito_(is_incognito),
       events_(EVENT_INITIATED),
       url_(url),
-      ukm_service_(ukm_service) {}
+      ukm_service_(ukm_service),
+      has_recorded_(false) {}
 
 JourneyLogger::~JourneyLogger() {}
 
 void JourneyLogger::IncrementSelectionAdds(Section section) {
   DCHECK_LT(section, SECTION_MAX);
   sections_[section].number_selection_adds_++;
 }
 
 void JourneyLogger::IncrementSelectionChanges(Section section) {
   DCHECK_LT(section, SECTION_MAX);
@@ skipping 19 matching lines @@
 void JourneyLogger::SetShowCalled() {
   was_show_called_ = true;
 }
 
 void JourneyLogger::SetEventOccurred(Event event) {
   events_ |= event;
 }
 
 void JourneyLogger::RecordJourneyStatsHistograms(
     CompletionStatus completion_status) {
+  // TODO: This should be a DCHECK once we make sure it's not called twice.

[Mathieu, 2017/05/02 20:56:47]

Making it a DCHECK now seems reasonable?

[sebsg, 2017/05/02 22:15:08]

It's not fixed at the moment, so the DCHECK would be triggered really often.
Updated the TODO with the bug number.

+  if (has_recorded_)
+    return;
+
+  has_recorded_ = true;
+
   RecordSectionSpecificStats(completion_status);
 
   // Record the CanMakePayment metrics based on whether the transaction was
   // completed or aborted by the user (UserAborted) or otherwise (OtherAborted).
   RecordCanMakePaymentStats(completion_status);
 
   RecordUrlKeyedMetrics(completion_status);
 }
 
 void JourneyLogger::RecordSectionSpecificStats(
@@ skipping 102 matching lines @@
   int32_t source_id = ukm_service_->GetNewSourceID();
   ukm_service_->UpdateSourceURL(source_id, url_);
   std::unique_ptr<ukm::UkmEntryBuilder> builder = ukm_service_->GetEntryBuilder(
       source_id, internal::kUKMCheckoutEventsEntryName);
   builder->AddMetric(internal::kUKMCompletionStatusMetricName,
                      completion_status);
   builder->AddMetric(internal::kUKMEventsMetricName, events_);
 }
 
 }  // namespace payments