[Payments] Record CanMakePayment metrics on Desktop.

components/payments/core/autofill_payment_instrument_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/core/autofill_payment_instrument.h"
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/payments/core/address_normalizer.h"
-#include "components/payments/core/payment_request_delegate.h"
+#include "components/payments/core/test_payment_request_delegate.h"
 #include "components/strings/grit/components_strings.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace payments {
 
 namespace {
 
 class FakePaymentInstrumentDelegate : public PaymentInstrument::Delegate {
  public:
@@ skipping 15 matching lines @@
 
   bool WasOnInstrumentDetailsErrorCalled() {
     return on_instrument_details_error_called_;
   }
 
  private:
   bool on_instrument_details_ready_called_ = false;
   bool on_instrument_details_error_called_ = false;
 };
 
-class FakeAddressNormalizer : public AddressNormalizer {
- public:
-  FakeAddressNormalizer() {}
-
-  void LoadRulesForRegion(const std::string& region_code) override {}
-
-  bool AreRulesLoadedForRegion(const std::string& region_code) override {
-    return true;
-  }
-
-  void StartAddressNormalization(
-      const autofill::AutofillProfile& profile,
-      const std::string& region_code,
-      int timeout_seconds,
-      AddressNormalizer::Delegate* requester) override {
-    profile_ = profile;
-    requester_ = requester;
-  }
-
-  void OnAddressValidationRulesLoaded(const std::string& region_code,
-                                      bool success) override {}
-
-  void CompleteAddressNormalization() {
-    requester_->OnAddressNormalized(profile_);
-  }
-
- private:
-  autofill::AutofillProfile profile_;
-  AddressNormalizer::Delegate* requester_;
-};
-
-class FakePaymentRequestDelegate : public PaymentRequestDelegate {
- public:
-  FakePaymentRequestDelegate()
-      : locale_("en-US"), last_committed_url_("https://shop.com") {}
-  void ShowDialog(PaymentRequest* request) override {}
-
-  void CloseDialog() override {}
-
-  void ShowErrorMessage() override {}
-
-  autofill::PersonalDataManager* GetPersonalDataManager() override {
-    return nullptr;
-  }
-
-  const std::string& GetApplicationLocale() const override { return locale_; }
-
-  bool IsIncognito() const override { return false; }
-
-  bool IsSslCertificateValid() override { return true; }
-
-  const GURL& GetLastCommittedURL() const override {
-    return last_committed_url_;
-  }
-
-  void DoFullCardRequest(
-      const autofill::CreditCard& credit_card,
-      base::WeakPtr<autofill::payments::FullCardRequest::ResultDelegate>
-          result_delegate) override {
-    full_card_request_card_ = credit_card;
-    full_card_result_delegate_ = result_delegate;
-  }
-
-  AddressNormalizer* GetAddressNormalizer() override {
-    return &address_normalizer_;
-  }
-
-  FakeAddressNormalizer* GetTestAddressNormalizer() {
-    return &address_normalizer_;
-  }
-
-  void CompleteFullCardRequest() {
-    full_card_result_delegate_->OnFullCardRequestSucceeded(
-        full_card_request_card_, base::ASCIIToUTF16("123"));
-  }
-
-  autofill::RegionDataLoader* GetRegionDataLoader() override { return nullptr; }
-
- private:
-  std::string locale_;
-  const GURL last_committed_url_;
-  FakeAddressNormalizer address_normalizer_;
-
-  autofill::CreditCard full_card_request_card_;
-  base::WeakPtr<autofill::payments::FullCardRequest::ResultDelegate>
-      full_card_result_delegate_;
-  DISALLOW_COPY_AND_ASSIGN(FakePaymentRequestDelegate);
-};
-
 }  // namespace
 
 class AutofillPaymentInstrumentTest : public testing::Test {
  protected:
   AutofillPaymentInstrumentTest()
       : address_(autofill::test::GetFullProfile()),
         local_card_(autofill::test::GetCreditCard()),
         billing_profiles_({&address_}) {
     local_card_.set_billing_address_id(address_.guid());
   }
@@ skipping 127 matching lines @@
   card.SetNumber(base::ASCIIToUTF16(""));
   AutofillPaymentInstrument instrument("visa", card, billing_profiles(),
                                        "en-US", nullptr);
   EXPECT_FALSE(instrument.IsValidForCanMakePayment());
 }
 
 // Tests that the autofill instrument only calls OnInstrumentDetailsReady when
 // the billing address has been normalized and the card has been unmasked.
 TEST_F(AutofillPaymentInstrumentTest,
        InvokePaymentApp_NormalizationBeforeUnmask) {
-  FakePaymentRequestDelegate delegate;
+  TestPaymentRequestDelegate delegate(/*personal_data_manager=*/nullptr);
+  delegate.DelayFullCardRequestCompletion();
+  delegate.GetTestAddressNormalizer()->DelayNormalization();
 
   autofill::CreditCard& card = local_credit_card();
   card.SetNumber(base::ASCIIToUTF16(""));
   AutofillPaymentInstrument instrument("visa", card, billing_profiles(),
                                        "en-US", &delegate);
 
   FakePaymentInstrumentDelegate instrument_delegate;
 
   instrument.InvokePaymentApp(&instrument_delegate);
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsReadyCalled());
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsErrorCalled());
 
   delegate.GetTestAddressNormalizer()->CompleteAddressNormalization();
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsReadyCalled());
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsErrorCalled());
 
   delegate.CompleteFullCardRequest();
   EXPECT_TRUE(instrument_delegate.WasOnInstrumentDetailsReadyCalled());
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsErrorCalled());
 }
 
 // Tests that the autofill instrument only calls OnInstrumentDetailsReady when
 // the billing address has been normalized and the card has been unmasked.
 TEST_F(AutofillPaymentInstrumentTest,
        InvokePaymentApp_UnmaskBeforeNormalization) {
-  FakePaymentRequestDelegate delegate;
+  TestPaymentRequestDelegate delegate(/*personal_data_manager=*/nullptr);
+  delegate.DelayFullCardRequestCompletion();

[Mathieu, 2017/05/02 20:56:47]

is this part of another change?

[sebsg, 2017/05/02 22:15:08]

Done.

+  delegate.GetTestAddressNormalizer()->DelayNormalization();
 
   autofill::CreditCard& card = local_credit_card();
   card.SetNumber(base::ASCIIToUTF16(""));
   AutofillPaymentInstrument instrument("visa", card, billing_profiles(),
                                        "en-US", &delegate);
 
   FakePaymentInstrumentDelegate instrument_delegate;
 
   instrument.InvokePaymentApp(&instrument_delegate);
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsReadyCalled());
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsErrorCalled());
 
   delegate.CompleteFullCardRequest();
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsReadyCalled());
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsErrorCalled());
 
   delegate.GetTestAddressNormalizer()->CompleteAddressNormalization();
   EXPECT_TRUE(instrument_delegate.WasOnInstrumentDetailsReadyCalled());
   EXPECT_FALSE(instrument_delegate.WasOnInstrumentDetailsErrorCalled());
 }
 
 }  // namespace payments