[inspector] entered into context before getPossibleBreakpoints call

src/inspector/v8-debugger-agent-impl.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-debugger-agent-impl.h"
 
 #include <algorithm>
 
 #include "src/debug/debug-interface.h"
 #include "src/inspector/injected-script.h"
@@ skipping 439 matching lines @@
     int line = end.fromJust()->getLineNumber();
     int column = end.fromJust()->getColumnNumber(0);
     if (line < 0 || column < 0)
       return Response::Error(
           "end.lineNumber and end.columnNumber should be >= 0");
     v8End = v8::debug::Location(line, column);
   }
   auto it = m_scripts.find(scriptId);
   if (it == m_scripts.end()) return Response::Error("Script not found");
 
+  int contextId = it->second->executionContextId();
+  int contextGroupId = m_inspector->contextGroupId(contextId);
+  InspectedContext* inspected =
+      m_inspector->getContext(contextGroupId, contextId);
+  if (!inspected) return Response::InternalError();

[dgozman, 2017/04/28 20:57:23]

I don't like this return. Sometimes we don't have a context for a script - we
should handle it gracefully.

[kozy, 2017/04/28 21:17:10]

I think I can use debuggerContext to fix a crash and later think about this
within debugger context removing work - we currently enter debugger context when
setting a breakpoint for the same reason.

+  v8::HandleScope handleScope(m_isolate);
+  v8::Context::Scope contextScope(inspected->context());
+
   std::vector<v8::debug::BreakLocation> v8Locations;
-  if (!it->second->getPossibleBreakpoints(
-          v8Start, v8End, restrictToFunction.fromMaybe(false), &v8Locations)) {
-    return Response::InternalError();
+
+  {
+    v8::TryCatch tryCatch(m_isolate);

[dgozman, 2017/04/28 20:57:23]

Put all scopes inside of {} block?

[kozy, 2017/04/28 21:17:10]

Done.

+    it->second->getPossibleBreakpoints(
+        v8Start, v8End, restrictToFunction.fromMaybe(false), &v8Locations);
   }
 
   *locations = protocol::Array<protocol::Debugger::BreakLocation>::create();
   for (size_t i = 0; i < v8Locations.size(); ++i) {
     std::unique_ptr<protocol::Debugger::BreakLocation> breakLocation =
         protocol::Debugger::BreakLocation::create()
             .setScriptId(scriptId)
             .setLineNumber(v8Locations[i].GetLineNumber())
             .setColumnNumber(v8Locations[i].GetColumnNumber())
             .build();
@@ skipping 812 matching lines @@
 
 void V8DebuggerAgentImpl::reset() {
   if (!enabled()) return;
   m_blackboxedPositions.clear();
   resetBlackboxedStateCache();
   m_scripts.clear();
   m_breakpointIdToDebuggerBreakpointIds.clear();
 }
 
 }  // namespace v8_inspector