 Chromium Code Reviews
 Chromium Code Reviews Issue 2851593002:
  Use ScopedTaskEnvironment instead of MessageLoopForUI in chrome tests.  (Closed)
    
  
    Issue 2851593002:
  Use ScopedTaskEnvironment instead of MessageLoopForUI in chrome tests.  (Closed) 
  | Index: chrome/browser/ui/omnibox/clipboard_utils_unittest.cc | 
| diff --git a/chrome/browser/ui/omnibox/clipboard_utils_unittest.cc b/chrome/browser/ui/omnibox/clipboard_utils_unittest.cc | 
| index 825f96e03d784925479906677d5e88c7113f745c..7dd23af75b336a8421f90ef04387e230170ca52b 100644 | 
| --- a/chrome/browser/ui/omnibox/clipboard_utils_unittest.cc | 
| +++ b/chrome/browser/ui/omnibox/clipboard_utils_unittest.cc | 
| @@ -2,12 +2,12 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| -#include "base/message_loop/message_loop.h" | 
| +#include "chrome/browser/ui/omnibox/clipboard_utils.h" | 
| 
sky
2017/04/27 22:17:46
newline between 5/6.
 
fdoray
2017/05/01 17:44:59
Done.
 | 
| #include "base/strings/string16.h" | 
| #include "base/strings/string_util.h" | 
| #include "base/strings/utf_string_conversions.h" | 
| +#include "base/test/scoped_task_environment.h" | 
| #include "build/build_config.h" | 
| -#include "chrome/browser/ui/omnibox/clipboard_utils.h" | 
| #include "testing/gtest/include/gtest/gtest.h" | 
| #include "testing/platform_test.h" | 
| #include "ui/base/clipboard/clipboard.h" | 
| @@ -19,13 +19,17 @@ namespace { | 
| class ClipboardUtilsTest : public PlatformTest { | 
| public: | 
| + ClipboardUtilsTest() | 
| + : scoped_task_environment_( | 
| + base::test::ScopedTaskEnvironment::MainThreadType::UI) {} | 
| + | 
| void TearDown() override { | 
| ui::Clipboard::DestroyClipboardForCurrentThread(); | 
| } | 
| private: | 
| // Windows requires a message loop for clipboard access. | 
| - base::MessageLoopForUI message_loop_; | 
| + base::test::ScopedTaskEnvironment scoped_task_environment_; | 
| }; | 
| TEST_F(ClipboardUtilsTest, GetClipboardText) { |