third_party/WebKit/Source/platform/bindings/ScopedPersistent.h - Issue 2851563004: Add documentation for platform/bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/bindings/ScopedPersistent.h

Issue 2851563004: Add documentation for platform/bindings (Closed)

Patch Set: Address code review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/bindings/ScopedPersistent.h

diff --git a/third_party/WebKit/Source/platform/bindings/ScopedPersistent.h b/third_party/WebKit/Source/platform/bindings/ScopedPersistent.h

index 2cf5ae2a90504f486215c7519d55a4903841680e..11e12a0e80cd09bc836a75f9489fccef745f331f 100644

--- a/third_party/WebKit/Source/platform/bindings/ScopedPersistent.h

+++ b/third_party/WebKit/Source/platform/bindings/ScopedPersistent.h

@@ -40,6 +40,10 @@

namespace blink {

+// Holds a persistent handle to a V8 object; use ScopedPersistent instead of

+// directly using v8::Persistent. Introducing a (non-weak) ScopedPersistent

+// has a risk of producing memory leaks, ask blink-reviews-bindings@ for a

+// review.

template <typename T>

class ScopedPersistent {

USING_FAST_MALLOC(ScopedPersistent);