Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/platform/bindings/V8ValueCache.h

Issue 2851563004: Add documentation for platform/bindings (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/bindings/V8ValueCache.h
diff --git a/third_party/WebKit/Source/platform/bindings/V8ValueCache.h b/third_party/WebKit/Source/platform/bindings/V8ValueCache.h
index f34d4b0ef4f2559471daac8fb146637fc0404e14..79f0f112361e65565a67dfe577a476ef64f068c3 100644
--- a/third_party/WebKit/Source/platform/bindings/V8ValueCache.h
+++ b/third_party/WebKit/Source/platform/bindings/V8ValueCache.h
@@ -74,6 +74,8 @@ class StringCacheMapTraits
static void DisposeWeak(const v8::WeakCallbackInfo<WeakCallbackDataType>&);
};
+// This class creates and caches v8::String objects. StringCache is held and can
jbroman 2017/04/28 19:07:03 nit: Maybe expand slightly to clarify that it cach
adithyas 2017/04/28 20:19:43 Ok updated, WDYT?
+// be retrieved from V8PerIsolateData.
class PLATFORM_EXPORT StringCache {
USING_FAST_MALLOC(StringCache);
WTF_MAKE_NONCOPYABLE(StringCache);

Powered by Google App Engine
This is Rietveld 408576698