Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: chrome/browser/ui/views/frame/avatar_button_manager.cc

Issue 2851543002: Update avatar button to MD (part 1) (Closed)
Patch Set: More review changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/avatar_button_manager.cc
diff --git a/chrome/browser/ui/views/frame/avatar_button_manager.cc b/chrome/browser/ui/views/frame/avatar_button_manager.cc
index 8101bf8b0e16bf11027d8b71cb84f1e4d0e38a71..598adbdc291d1e4e956f4ec3892516c1856e6228 100644
--- a/chrome/browser/ui/views/frame/avatar_button_manager.cc
+++ b/chrome/browser/ui/views/frame/avatar_button_manager.cc
@@ -6,10 +6,19 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/themes/theme_service.h"
+#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/view_ids.h"
#include "chrome/browser/ui/views/frame/browser_frame.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
-#include "chrome/browser/ui/views/profiles/new_avatar_button.h"
+#include "chrome/browser/ui/views/profiles/avatar_button.h"
+#include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
+#include "chrome/browser/ui/views/profiles/themed_avatar_button.h"
+
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#include "chrome/browser/ui/views/profiles/win10_native_avatar_button.h"
+#endif
AvatarButtonManager::AvatarButtonManager(BrowserNonClientFrameView* frame_view)
: frame_view_(frame_view), view_(nullptr) {}
@@ -31,7 +40,19 @@ void AvatarButtonManager::Update(AvatarButtonStyle style) {
// Desktop guest shows the avatar button.
browser_view->IsIncognito()) {
if (!view_) {
- view_ = new NewAvatarButton(this, style, profile);
+#if defined(OS_WIN)
+ // TODO: use MD button in other cases, too [http://crbug.com/591586]
+ if ((base::win::GetVersion() >= base::win::VERSION_WIN10) &&
+ ThemeServiceFactory::GetForProfile(profile)->UsingSystemTheme()) {
+ DCHECK_EQ(AvatarButtonStyle::NATIVE, style);
+ view_ = new Win10NativeAvatarButton(this, profile);
+ } else {
+ view_ = new ThemedAvatarButton(this, style, profile);
+ }
+#else
+ view_ = new ThemedAvatarButton(this, style, profile);
+#endif // defined(OS_WIN)
+
view_->set_id(VIEW_ID_AVATAR_BUTTON);
frame_view_->AddChildView(view_);
frame->GetRootView()->Layout();
@@ -43,26 +64,16 @@ void AvatarButtonManager::Update(AvatarButtonStyle style) {
}
}
-void AvatarButtonManager::ButtonPreferredSizeChanged() {
- // Perform a re-layout if the avatar button has changed, since that can affect
- // the size of the tabs.
- if (!view_ || !frame_view_->browser_view()->initialized())
- return; // Ignore the update during view creation.
-
- frame_view_->InvalidateLayout();
- frame_view_->frame()->GetRootView()->Layout();
-}
-
-void AvatarButtonManager::ButtonPressed(views::Button* sender,
- const ui::Event& event) {
- DCHECK_EQ(view_, sender);
+void AvatarButtonManager::OnMenuButtonClicked(views::MenuButton* source,
+ const gfx::Point& point,
+ const ui::Event* event) {
+ DCHECK_EQ(view_, source);
BrowserWindow::AvatarBubbleMode mode =
BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT;
- if ((event.IsMouseEvent() &&
- static_cast<const ui::MouseEvent&>(event).IsRightMouseButton()) ||
- (event.type() == ui::ET_GESTURE_LONG_PRESS)) {
+
+ if (event && event->type() == ui::ET_GESTURE_LONG_PRESS)
return;
- }
+
frame_view_->browser_view()->ShowAvatarBubbleFromAvatarButton(
mode, signin::ManageAccountsParams(),
signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, false);

Powered by Google App Engine
This is Rietveld 408576698