Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/ui/views/profiles/new_avatar_button.cc

Issue 2851543002: Update avatar button to MD (part 1) (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/profiles/new_avatar_button.h" 5 #include "chrome/browser/ui/views/profiles/new_avatar_button.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "chrome/app/vector_icons/vector_icons.h" 10 #include "chrome/app/vector_icons/vector_icons.h"
11 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
12 #include "chrome/browser/profiles/profile_attributes_entry.h" 12 #include "chrome/browser/profiles/profile_attributes_entry.h"
13 #include "chrome/browser/profiles/profile_manager.h" 13 #include "chrome/browser/profiles/profile_manager.h"
14 #include "chrome/browser/profiles/profiles_state.h" 14 #include "chrome/browser/profiles/profiles_state.h"
15 #include "chrome/browser/signin/signin_manager_factory.h"
15 #include "chrome/browser/ui/views/profiles/avatar_button_delegate.h" 16 #include "chrome/browser/ui/views/profiles/avatar_button_delegate.h"
16 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h" 17 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
18 #include "chrome/browser/ui/views/tabs/tab_strip.h"
17 #include "chrome/grit/theme_resources.h" 19 #include "chrome/grit/theme_resources.h"
18 #include "components/signin/core/common/profile_management_switches.h" 20 #include "components/signin/core/common/profile_management_switches.h"
19 #include "ui/base/resource/resource_bundle.h" 21 #include "ui/base/resource/resource_bundle.h"
20 #include "ui/gfx/canvas.h" 22 #include "ui/gfx/canvas.h"
21 #include "ui/gfx/color_palette.h" 23 #include "ui/gfx/color_palette.h"
22 #include "ui/gfx/geometry/vector2d.h" 24 #include "ui/gfx/geometry/vector2d.h"
23 #include "ui/gfx/paint_vector_icon.h" 25 #include "ui/gfx/paint_vector_icon.h"
24 #include "ui/vector_icons/vector_icons.h" 26 #include "ui/vector_icons/vector_icons.h"
27 #include "ui/views/animation/flood_fill_ink_drop_ripple.h"
28 #include "ui/views/animation/ink_drop_impl.h"
25 #include "ui/views/border.h" 29 #include "ui/views/border.h"
26 #include "ui/views/controls/button/label_button_border.h" 30 #include "ui/views/controls/button/label_button_border.h"
27 #include "ui/views/painter.h" 31 #include "ui/views/painter.h"
28 32
29 #if defined(OS_WIN) 33 #if defined(OS_WIN)
30 #include "base/win/windows_version.h" 34 #include "base/win/windows_version.h"
31 #endif 35 #endif
32 36
33 namespace { 37 // Minimum and maximum width of the MD button
38 const int kMdButtonMinWidth = 48;
39 const int kMdButtonMaxWidth = 96;
40 // Height of the non-MD (pre-Windows 10) button
41 const int kButtonNonMdHeight = 20;
42 // Height of the "cozy" MD button that ("tall" MD button height is computed)
43 const int kButtonMdCozyHeight = 20;
44 const int kButtonMdIconHeight = 16;
45 const SkColor kButtonMdIconColor = SkColorSetARGB(138, 0, 0, 0); // Alpha 54%
46 // Opacity of the ink drop on hover
47 const float kHighlightInkDropOpacity = 0.08f;
48 // Opacity of the ink drop on click, which is added to kHighlightInkDropOpacity
49 const float kRippleInkDropOpacity = 0.04f;
34 50
35 std::unique_ptr<views::Border> CreateBorder(const int normal_image_set[], 51 AvatarButton::AvatarButton(AvatarButtonDelegate* delegate, Profile* profile)
36 const int hot_image_set[], 52 : MenuButton(base::string16(), delegate, false),
37 const int pushed_image_set[]) {
38 std::unique_ptr<views::LabelButtonAssetBorder> border(
39 new views::LabelButtonAssetBorder(views::Button::STYLE_TEXTBUTTON));
40 border->SetPainter(false, views::Button::STATE_NORMAL,
41 views::Painter::CreateImageGridPainter(normal_image_set));
42 border->SetPainter(false, views::Button::STATE_HOVERED,
43 views::Painter::CreateImageGridPainter(hot_image_set));
44 border->SetPainter(false, views::Button::STATE_PRESSED,
45 views::Painter::CreateImageGridPainter(pushed_image_set));
46
47 const int kLeftRightInset = 8;
48 const int kTopInset = 2;
49 const int kBottomInset = 4;
50 border->set_insets(gfx::Insets(kTopInset, kLeftRightInset,
51 kBottomInset, kLeftRightInset));
52
53 return std::move(border);
54 }
55
56 } // namespace
57
58 NewAvatarButton::NewAvatarButton(AvatarButtonDelegate* delegate,
59 AvatarButtonStyle button_style,
60 Profile* profile)
61 : LabelButton(delegate, base::string16()),
62 delegate_(delegate), 53 delegate_(delegate),
63 error_controller_(this, profile), 54 error_controller_(this, profile),
64 profile_(profile), 55 profile_(profile) {
65 suppress_mouse_released_action_(false) { 56 set_notify_action(CustomButton::NOTIFY_ON_PRESS);
66 set_triggerable_event_flags( 57 set_triggerable_event_flags(ui::EF_LEFT_MOUSE_BUTTON |
67 ui::EF_LEFT_MOUSE_BUTTON | ui::EF_RIGHT_MOUSE_BUTTON); 58 ui::EF_RIGHT_MOUSE_BUTTON);
68 set_animate_on_state_change(false); 59 set_animate_on_state_change(false);
69 SetEnabledTextColors(SK_ColorWHITE); 60 SetEnabledTextColors(SK_ColorWHITE);
70 SetTextSubpixelRenderingEnabled(false); 61 SetTextSubpixelRenderingEnabled(false);
71 SetHorizontalAlignment(gfx::ALIGN_CENTER); 62 SetHorizontalAlignment(gfx::ALIGN_CENTER);
72 63
64 g_browser_process->profile_manager()
65 ->GetProfileAttributesStorage()
66 .AddObserver(this);
67
73 // The largest text height that fits in the button. If the font list height 68 // The largest text height that fits in the button. If the font list height
74 // is larger than this, it will be shrunk to match it. 69 // is larger than this, it will be shrunk to match it.
75 // TODO(noms): Calculate this constant algorithmically from the button's size. 70 // TODO(noms): Calculate this constant algorithmically from the button's size.
76 const int kDisplayFontHeight = 16; 71 const int kDisplayFontHeight = 16;
77 SetFontList( 72 SetFontList(
78 label()->font_list().DeriveWithHeightUpperBound(kDisplayFontHeight)); 73 label()->font_list().DeriveWithHeightUpperBound(kDisplayFontHeight));
79
80 ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
81 if (button_style == AvatarButtonStyle::THEMED) {
82 const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_THEMED_BUTTON_NORMAL);
83 const int kHotImageSet[] = IMAGE_GRID(IDR_AVATAR_THEMED_BUTTON_HOVER);
84 const int kPushedImageSet[] = IMAGE_GRID(IDR_AVATAR_THEMED_BUTTON_PRESSED);
85
86 SetBorder(CreateBorder(kNormalImageSet, kHotImageSet, kPushedImageSet));
87 generic_avatar_ =
88 *rb->GetImageNamed(IDR_AVATAR_THEMED_BUTTON_AVATAR).ToImageSkia();
89 #if defined(OS_WIN)
90 } else if (base::win::GetVersion() < base::win::VERSION_WIN8) {
91 const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_NORMAL);
92 const int kHotImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_HOVER);
93 const int kPushedImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_PRESSED);
94
95 SetBorder(CreateBorder(kNormalImageSet, kHotImageSet, kPushedImageSet));
96 generic_avatar_ =
97 *rb->GetImageNamed(IDR_AVATAR_GLASS_BUTTON_AVATAR).ToImageSkia();
98 #endif
99 } else {
100 const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_NATIVE_BUTTON_NORMAL);
101 const int kHotImageSet[] = IMAGE_GRID(IDR_AVATAR_NATIVE_BUTTON_HOVER);
102 const int kPushedImageSet[] = IMAGE_GRID(IDR_AVATAR_NATIVE_BUTTON_PRESSED);
103
104 SetBorder(CreateBorder(kNormalImageSet, kHotImageSet, kPushedImageSet));
105 generic_avatar_ =
106 *rb->GetImageNamed(IDR_AVATAR_NATIVE_BUTTON_AVATAR).ToImageSkia();
107 }
108
109 g_browser_process->profile_manager()->
110 GetProfileAttributesStorage().AddObserver(this);
111 Update();
112 SchedulePaint();
113 } 74 }
114 75
115 NewAvatarButton::~NewAvatarButton() { 76 AvatarButton::~AvatarButton() {
116 g_browser_process->profile_manager()-> 77 g_browser_process->profile_manager()
117 GetProfileAttributesStorage().RemoveObserver(this); 78 ->GetProfileAttributesStorage()
79 .RemoveObserver(this);
118 } 80 }
119 81
120 bool NewAvatarButton::OnMousePressed(const ui::MouseEvent& event) { 82 bool AvatarButton::IsTriggerableEvent(const ui::Event& event) {
121 // Prevent the bubble from being re-shown if it's already showing. 83 return event.type() == ui::ET_GESTURE_LONG_PRESS ||
122 suppress_mouse_released_action_ = ProfileChooserView::IsShowing(); 84 MenuButton::IsTriggerableEvent(event);
123 return LabelButton::OnMousePressed(event);
124 } 85 }
125 86
126 void NewAvatarButton::OnMouseReleased(const ui::MouseEvent& event) { 87 void AvatarButton::OnAvatarErrorChanged() {
127 if (suppress_mouse_released_action_)
128 suppress_mouse_released_action_ = false;
129 else
130 LabelButton::OnMouseReleased(event);
131 }
132
133 void NewAvatarButton::OnGestureEvent(ui::GestureEvent* event) {
134 // TODO(wjmaclean): The check for ET_GESTURE_LONG_PRESS is done here since
135 // no other UI button based on CustomButton appears to handle mouse
136 // right-click. If other cases are identified, it may make sense to move this
137 // check to CustomButton.
138 if (event->type() == ui::ET_GESTURE_LONG_PRESS)
139 NotifyClick(*event);
140 else
141 LabelButton::OnGestureEvent(event);
142 }
143
144 void NewAvatarButton::OnAvatarErrorChanged() {
145 Update(); 88 Update();
146 } 89 }
147 90
148 void NewAvatarButton::OnProfileAdded(const base::FilePath& profile_path) { 91 void AvatarButton::OnProfileAdded(const base::FilePath& profile_path) {
149 Update(); 92 Update();
150 } 93 }
151 94
152 void NewAvatarButton::OnProfileWasRemoved( 95 void AvatarButton::OnProfileWasRemoved(const base::FilePath& profile_path,
153 const base::FilePath& profile_path, 96 const base::string16& profile_name) {
154 const base::string16& profile_name) {
155 // If deleting the active profile, don't bother updating the avatar 97 // If deleting the active profile, don't bother updating the avatar
156 // button, as the browser window is being closed anyway. 98 // button, as the browser window is being closed anyway.
157 if (profile_->GetPath() != profile_path) 99 if (profile_->GetPath() != profile_path)
158 Update(); 100 Update();
159 } 101 }
160 102
161 void NewAvatarButton::OnProfileNameChanged( 103 void AvatarButton::OnProfileNameChanged(
162 const base::FilePath& profile_path, 104 const base::FilePath& profile_path,
163 const base::string16& old_profile_name) { 105 const base::string16& old_profile_name) {
164 if (profile_->GetPath() == profile_path) 106 if (profile_->GetPath() == profile_path)
165 Update(); 107 Update();
166 } 108 }
167 109
168 void NewAvatarButton::OnProfileSupervisedUserIdChanged( 110 void AvatarButton::OnProfileSupervisedUserIdChanged(
169 const base::FilePath& profile_path) { 111 const base::FilePath& profile_path) {
170 if (profile_->GetPath() == profile_path) 112 if (profile_->GetPath() == profile_path)
171 Update(); 113 Update();
172 } 114 }
173 115
174 void NewAvatarButton::Update() { 116 void AvatarButton::Update() {
175 ProfileAttributesStorage& storage = 117 ProfileAttributesStorage& storage =
176 g_browser_process->profile_manager()->GetProfileAttributesStorage(); 118 g_browser_process->profile_manager()->GetProfileAttributesStorage();
177 119
178 // If we have a single local profile, then use the generic avatar 120 // If we have a single local profile, then use the generic avatar
179 // button instead of the profile name. Never use the generic button if 121 // button instead of the profile name. Never use the generic button if
180 // the active profile is Guest. 122 // the active profile is Guest.
181 const bool use_generic_button = 123 const bool use_generic_button =
182 !profile_->IsGuestSession() && 124 !profile_->IsGuestSession() && storage.GetNumberOfProfiles() == 1 &&
183 storage.GetNumberOfProfiles() == 1 && 125 !SigninManagerFactory::GetForProfile(profile_)->IsAuthenticated();
184 !storage.GetAllProfilesAttributes().front()->IsAuthenticated();
185 126
127 UpdateButton(use_generic_button);
128
129 PreferredSizeChanged();
130 delegate_->ButtonPreferredSizeChanged();
131 }
132
133 void AvatarButton::UpdateButton(bool use_generic_button) {
186 SetText(use_generic_button 134 SetText(use_generic_button
187 ? base::string16() 135 ? base::string16()
188 : profiles::GetAvatarButtonTextForProfile(profile_)); 136 : profiles::GetAvatarButtonTextForProfile(profile_));
189 137
190 // If the button has no text, clear the text shadows to make sure the 138 // If the button has no text, clear the text shadows to make sure the
191 // image is centered correctly. 139 // image is centered correctly.
192 SetTextShadows( 140 SetTextShadows(
193 use_generic_button 141 use_generic_button
194 ? gfx::ShadowValues() 142 ? gfx::ShadowValues()
195 : gfx::ShadowValues( 143 : gfx::ShadowValues(
196 10, gfx::ShadowValue(gfx::Vector2d(), 2.0f, SK_ColorDKGRAY))); 144 10, gfx::ShadowValue(gfx::Vector2d(), 2.0f, SK_ColorDKGRAY)));
197 145
198 // We want the button to resize if the new text is shorter. 146 // We want the button to resize if the new text is shorter.
199 SetMinSize(gfx::Size()); 147 SetMinSize(gfx::Size());
200 148
201 if (use_generic_button) { 149 if (use_generic_button) {
202 SetImage(views::Button::STATE_NORMAL, generic_avatar_); 150 SetImage(views::Button::STATE_NORMAL, generic_avatar_);
203 } else if (error_controller_.HasAvatarError()) { 151 } else if (error_controller_.HasAvatarError()) {
204 SetImage(views::Button::STATE_NORMAL, 152 SetImage(views::Button::STATE_NORMAL,
205 gfx::CreateVectorIcon(kSyncProblemIcon, 16, gfx::kGoogleRed700)); 153 gfx::CreateVectorIcon(kSyncProblemIcon, 16, gfx::kGoogleRed700));
206 } else { 154 } else {
207 SetImage(views::Button::STATE_NORMAL, gfx::ImageSkia()); 155 SetImage(views::Button::STATE_NORMAL, gfx::ImageSkia());
208 } 156 }
209 157
210 // If we are not using the generic button, then reset the spacing between 158 // If we are not using the generic button, then reset the spacing between
211 // the text and the possible authentication error icon. 159 // the text and the possible authentication error icon.
212 const int kDefaultImageTextSpacing = 5; 160 const int kDefaultImageTextSpacing = 5;
213 SetImageLabelSpacing(use_generic_button ? 0 : kDefaultImageTextSpacing); 161 SetImageLabelSpacing(use_generic_button ? 0 : kDefaultImageTextSpacing);
162 }
214 163
215 PreferredSizeChanged(); 164 //-----------------------------------------------------------------------
216 delegate_->ButtonPreferredSizeChanged(); 165 //-----------------------------------------------------------------------
166 //-----------------------------------------------------------------------
167
168 NewAvatarButton::NewAvatarButton(AvatarButtonDelegate* delegate,
169 AvatarButtonStyle button_style,
170 Profile* profile)
171 : AvatarButton(delegate, profile) {
172 if (button_style == AvatarButtonStyle::THEMED) {
173 const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_THEMED_BUTTON_NORMAL);
174 const int kHoverImageSet[] = IMAGE_GRID(IDR_AVATAR_THEMED_BUTTON_HOVER);
175 const int kPressedImageSet[] = IMAGE_GRID(IDR_AVATAR_THEMED_BUTTON_PRESSED);
176 SetButtonAvatar(IDR_AVATAR_THEMED_BUTTON_AVATAR);
177 SetBorder(CreateBorder(kNormalImageSet, kHoverImageSet, kPressedImageSet));
178 #if defined(OS_WIN)
179 } else if (base::win::GetVersion() < base::win::VERSION_WIN8) {
180 const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_NORMAL);
181 const int kHoverImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_HOVER);
182 const int kPressedImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_PRESSED);
183 SetButtonAvatar(IDR_AVATAR_GLASS_BUTTON_AVATAR);
184 SetBorder(CreateBorder(kNormalImageSet, kHoverImageSet, kPressedImageSet));
185 #endif
186 } else {
187 const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_NATIVE_BUTTON_NORMAL);
188 const int kHoverImageSet[] = IMAGE_GRID(IDR_AVATAR_NATIVE_BUTTON_HOVER);
189 const int kPressedImageSet[] = IMAGE_GRID(IDR_AVATAR_NATIVE_BUTTON_PRESSED);
190 SetButtonAvatar(IDR_AVATAR_NATIVE_BUTTON_AVATAR);
191 SetBorder(CreateBorder(kNormalImageSet, kHoverImageSet, kPressedImageSet));
192 }
193
194 Update();
195 SchedulePaint();
217 } 196 }
197
198 NewAvatarButton::~NewAvatarButton() {}
199
200 gfx::Size NewAvatarButton::GetPreferredSize() const {
201 gfx::Size size = views::MenuButton::GetPreferredSize();
202 size.set_height(kButtonNonMdHeight);
203 return size;
204 }
205
206 std::unique_ptr<views::Border> NewAvatarButton::CreateBorder(
207 const int normal_image_set[],
208 const int hot_image_set[],
209 const int pushed_image_set[]) const {
210 std::unique_ptr<views::LabelButtonAssetBorder> border(
211 new views::LabelButtonAssetBorder(views::Button::STYLE_TEXTBUTTON));
212
213 border->SetPainter(false, views::Button::STATE_NORMAL,
214 views::Painter::CreateImageGridPainter(normal_image_set));
215 border->SetPainter(false, views::Button::STATE_HOVERED,
216 views::Painter::CreateImageGridPainter(hot_image_set));
217 border->SetPainter(false, views::Button::STATE_PRESSED,
218 views::Painter::CreateImageGridPainter(pushed_image_set));
219
220 const int kLeftRightInset = 8;
221 const int kTopInset = 2;
222 const int kBottomInset = 4;
223 border->set_insets(
224 gfx::Insets(kTopInset, kLeftRightInset, kBottomInset, kLeftRightInset));
225
226 return std::move(border);
227 }
228
229 void NewAvatarButton::SetButtonAvatar(int avatar_idr) {
230 ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
231 set_generic_avatar(*rb->GetImageNamed(avatar_idr).ToImageSkia());
232 }
233
234 //-----------------------------------------------------------------------
235 //-----------------------------------------------------------------------
236 //-----------------------------------------------------------------------
237
238 MaterialDesignAvatarButton::MaterialDesignAvatarButton(
239 AvatarButtonDelegate* delegate,
240 Profile* profile,
241 BrowserView* browser_view)
242 : AvatarButton(delegate, profile), browser_view_(browser_view) {
243 DCHECK(browser_view);
244
245 set_generic_avatar(gfx::CreateVectorIcon(
246 kAccountCircleIcon, kButtonMdIconHeight, kButtonMdIconColor));
247 SetBorder(CreateBorder());
248
249 Update();
250 SchedulePaint();
251
252 SetInkDropMode(InkDropMode::ON);
253 set_has_ink_drop_action_on_click(true);
254 SetFocusPainter(nullptr);
255 set_ink_drop_base_color(SK_ColorBLACK);
256 set_ink_drop_visible_opacity(kRippleInkDropOpacity);
257 }
258
259 MaterialDesignAvatarButton::~MaterialDesignAvatarButton() {}
260
261 gfx::Size MaterialDesignAvatarButton::GetPreferredSize() const {
262 gfx::Size ps = views::MenuButton::GetPreferredSize();
263 ps.set_width(
264 std::min(std::max(ps.width(), kMdButtonMinWidth), kMdButtonMaxWidth));
265 // TODO(emx): get the proper height here - see http://crrev/2833363002
266 ps.set_height(30);
267 return ps;
268 }
269
270 std::unique_ptr<views::Border> MaterialDesignAvatarButton::CreateBorder()
271 const {
272 // These insets look OK at 100%, 125%, 150%, 175% and 200% scaling.
273 const int kLeftRightInset = 8;
274 const int kTopInset = 1;
275 const int kBottomInset = 3;
276 return views::CreateEmptyBorder(kTopInset, kLeftRightInset, kBottomInset,
277 kLeftRightInset);
278 }
279
280 std::unique_ptr<views::InkDrop> MaterialDesignAvatarButton::CreateInkDrop() {
281 return CreateDefaultFloodFillInkDropImpl();
282 }
283
284 std::unique_ptr<views::InkDropHighlight>
285 MaterialDesignAvatarButton::CreateInkDropHighlight() const {
286 auto center = gfx::RectF(gfx::Rect(size())).CenterPoint();
287 auto ink_drop_highlight = base::MakeUnique<views::InkDropHighlight>(
288 size(), 0, center, GetInkDropBaseColor());
289 ink_drop_highlight->set_visible_opacity(kHighlightInkDropOpacity);
290 return ink_drop_highlight;
291 }
292
293 std::unique_ptr<views::InkDropRipple>
294 MaterialDesignAvatarButton::CreateInkDropRipple() const {
295 return base::MakeUnique<views::FloodFillInkDropRipple>(
296 size(), GetInkDropCenterBasedOnLastEvent(), GetInkDropBaseColor(),
297 ink_drop_visible_opacity());
298 }
299
300 void MaterialDesignAvatarButton::UpdateButtonHeightForPosition(
301 const int button_x,
302 int* button_height) const {
303 TabStrip* tab_strip = browser_view_->tabstrip();
304 if (!tab_strip)
305 return;
306
307 // In RTL the new tab button is on the left, so it can never slide under the
308 // avatar button (which is still on the right). May as well use the space.
309 if (base::i18n::IsRTL())
310 return;
311
312 // Use the "cozy" button if the tabstrip can slide under it
313 if (tab_strip->max_x() >= button_x) {
314 *button_height = kButtonMdCozyHeight;
315 }
316 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698