chrome/browser/ui/views/profiles/avatar_button_delegate.h - Issue 2851543002: Update avatar button to MD (part 1)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/profiles/avatar_button_delegate.h

Issue 2851543002: Update avatar button to MD (part 1) (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/frame/avatar_button_manager.h ('K') | « chrome/browser/ui/views/frame/opaque_browser_frame_view.cc ('k') | chrome/browser/ui/views/profiles/new_avatar_button.h » ('j') | chrome/browser/ui/views/profiles/new_avatar_button.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BUTTON_DELEGATE_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BUTTON_DELEGATE_H_

6 #define CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BUTTON_DELEGATE_H_	6 #define CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BUTTON_DELEGATE_H_

7	7

8 #include "ui/views/controls/button/button.h"	8 #include "ui/views/controls/button/menu_button_listener.h"

9	9

10 // Delegate allowing NewAvatarButton to communicate back to its manager.	10 // Delegate allowing NewAvatarButton to communicate back to its manager.

11 class AvatarButtonDelegate : public views::ButtonListener {	11 class AvatarButtonDelegate : public views::MenuButtonListener {

12 public:	12 public:

13 // Called when the preferred size changed, e.g., due to a profile name change.	13 // Called when the preferred size changed, e.g., due to a profile name change.

14 virtual void ButtonPreferredSizeChanged() = 0;	14 virtual void ButtonPreferredSizeChanged() = 0;
	Evan Stade 2017/04/27 17:15:02 this is not your doing, but it seems like we shoul this is not your doing, but it seems like we shouldn't need this but could instead use View::PreferredSizeChanged() and View::ChildPreferredSizeChanged(View* child). The appropriate view that holds the button can check if the child matches the avatar button and act accordingly. This would eliminate this class and simplify AvatarButtonManager, and delete this code which seems out of place in that class: frame_view_->InvalidateLayout(); frame_view_->frame()->GetRootView()->Layout(); emx 2017/04/28 12:39:40 Thanks, this simplifies things quite a bit! Show quoted text On 2017/04/27 17:15:02, Evan Stade wrote: > this is not your doing, but it seems like we shouldn't need this but could > instead use View::PreferredSizeChanged() and > View::ChildPreferredSizeChanged(View* child). The appropriate view that holds > the button can check if the child matches the avatar button and act accordingly. > This would eliminate this class and simplify AvatarButtonManager, and delete > this code which seems out of place in that class: > > frame_view_->InvalidateLayout(); > frame_view_->frame()->GetRootView()->Layout(); Thanks, this simplifies things quite a bit!
15 };	15 };

16	16

17 #endif // CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BUTTON_DELEGATE_H_	17 #endif // CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BUTTON_DELEGATE_H_

OLD	NEW