Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: net/url_request/report_sender.h

Issue 2851493003: Remove unused CookiePreferences from report sender and never send cookies (Closed)
Patch Set: Fix rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc ('k') | net/url_request/report_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/report_sender.h
diff --git a/net/url_request/report_sender.h b/net/url_request/report_sender.h
index 6bfc72ced5397652a11ff407172a8358e938d9c9..7ba8302cabe1cf401233f777cc63344d1b2c26af 100644
--- a/net/url_request/report_sender.h
+++ b/net/url_request/report_sender.h
@@ -34,15 +34,10 @@ class NET_EXPORT ReportSender
using ErrorCallback = base::Callback<
void(const GURL&, int /* net_error */, int /* http_response_code */)>;
- // Represents whether or not to send cookies along with reports.
- enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES };
-
// Constructs a ReportSender that sends reports with the
- // given |request_context| and includes or excludes cookies based on
- // |cookies_preference|. |request_context| must outlive the
- // ReportSender.
- ReportSender(URLRequestContext* request_context,
- CookiesPreference cookies_preference);
+ // given |request_context|, always excluding cookies. |request_context| must
+ // outlive the ReportSender.
+ explicit ReportSender(URLRequestContext* request_context);
~ReportSender() override;
@@ -59,9 +54,6 @@ class NET_EXPORT ReportSender
private:
net::URLRequestContext* const request_context_;
-
- CookiesPreference cookies_preference_;
-
std::map<URLRequest*, std::unique_ptr<URLRequest>> inflight_requests_;
DISALLOW_COPY_AND_ASSIGN(ReportSender);
« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc ('k') | net/url_request/report_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698