Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: net/url_request/report_sender.h

Issue 2851493003: Remove unused CookiePreferences from report sender and never send cookies (Closed)
Patch Set: Fix iOS build Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/report_sender.h
diff --git a/net/url_request/report_sender.h b/net/url_request/report_sender.h
index a230f0603b1a9b5a769ade2f65b3e133eb509664..7506071680d754e7ef3a4d58507f110b6c9e3883 100644
--- a/net/url_request/report_sender.h
+++ b/net/url_request/report_sender.h
@@ -33,15 +33,10 @@ class NET_EXPORT ReportSender
using SuccessCallback = base::Callback<void()>;
using ErrorCallback = base::Callback<void(const GURL&, int)>;
- // Represents whether or not to send cookies along with reports.
- enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES };
-
// Constructs a ReportSender that sends reports with the
- // given |request_context| and includes or excludes cookies based on
- // |cookies_preference|. |request_context| must outlive the
- // ReportSender.
- ReportSender(URLRequestContext* request_context,
- CookiesPreference cookies_preference);
+ // given |request_context|, always excluding cookies. |request_context| must
+ // outlive the ReportSender.
+ explicit ReportSender(URLRequestContext* request_context);
~ReportSender() override;
@@ -58,9 +53,6 @@ class NET_EXPORT ReportSender
private:
net::URLRequestContext* const request_context_;
-
- CookiesPreference cookies_preference_;
-
std::map<URLRequest*, std::unique_ptr<URLRequest>> inflight_requests_;
DISALLOW_COPY_AND_ASSIGN(ReportSender);

Powered by Google App Engine
This is Rietveld 408576698