Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/safe_browsing/certificate_reporting_service.cc

Issue 2851493003: Remove unused CookiePreferences from report sender and never send cookies (Closed)
Patch Set: Fix iOS build Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "chrome/browser/safe_browsing/certificate_reporting_service.h" 4 #include "chrome/browser/safe_browsing/certificate_reporting_service.h"
5 5
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/metrics/sparse_histogram.h" 8 #include "base/metrics/sparse_histogram.h"
9 #include "base/time/clock.h" 9 #include "base/time/clock.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 uint32_t server_public_key_version) { 296 uint32_t server_public_key_version) {
297 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 297 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
298 // url_request_context_ is null during shutdown. 298 // url_request_context_ is null during shutdown.
299 if (!enabled || !url_request_context) { 299 if (!enabled || !url_request_context) {
300 reporter_.reset(); 300 reporter_.reset();
301 return; 301 return;
302 } 302 }
303 std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter; 303 std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter;
304 if (server_public_key) { 304 if (server_public_key) {
305 // Only used in tests. 305 // Only used in tests.
306 std::unique_ptr<net::ReportSender> report_sender(new net::ReportSender( 306 std::unique_ptr<net::ReportSender> report_sender(
307 url_request_context, net::ReportSender::DO_NOT_SEND_COOKIES)); 307 new net::ReportSender(url_request_context));
308 error_reporter.reset(new certificate_reporting::ErrorReporter( 308 error_reporter.reset(new certificate_reporting::ErrorReporter(
309 GURL(kExtendedReportingUploadUrl), server_public_key, 309 GURL(kExtendedReportingUploadUrl), server_public_key,
310 server_public_key_version, std::move(report_sender))); 310 server_public_key_version, std::move(report_sender)));
311 } else { 311 } else {
312 error_reporter.reset(new certificate_reporting::ErrorReporter( 312 error_reporter.reset(new certificate_reporting::ErrorReporter(
313 url_request_context, GURL(kExtendedReportingUploadUrl), 313 url_request_context, GURL(kExtendedReportingUploadUrl)));
314 net::ReportSender::DO_NOT_SEND_COOKIES));
315 } 314 }
316 reporter_.reset( 315 reporter_.reset(
317 new Reporter(std::move(error_reporter), 316 new Reporter(std::move(error_reporter),
318 std::unique_ptr<BoundedReportList>( 317 std::unique_ptr<BoundedReportList>(
319 new BoundedReportList(max_queued_report_count)), 318 new BoundedReportList(max_queued_report_count)),
320 clock, max_report_age, true /* retries_enabled */)); 319 clock, max_report_age, true /* retries_enabled */));
321 } 320 }
322 321
323 void CertificateReportingService::OnPreferenceChanged() { 322 void CertificateReportingService::OnPreferenceChanged() {
324 safe_browsing::SafeBrowsingService* safe_browsing_service_ = 323 safe_browsing::SafeBrowsingService* safe_browsing_service_ =
325 g_browser_process->safe_browsing_service(); 324 g_browser_process->safe_browsing_service();
326 const bool enabled = safe_browsing_service_ && 325 const bool enabled = safe_browsing_service_ &&
327 safe_browsing_service_->enabled_by_prefs() && 326 safe_browsing_service_->enabled_by_prefs() &&
328 safe_browsing::IsExtendedReportingEnabled(pref_service_); 327 safe_browsing::IsExtendedReportingEnabled(pref_service_);
329 SetEnabled(enabled); 328 SetEnabled(enabled);
330 } 329 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698