Mark some non-spinvalidation methods deprecated, and update paint/README.md

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1344 matching lines @@
 #if DCHECK_IS_ON()
   // Post-layout assert that nobody was re-marked as needing layout during
   // layout.
   GetLayoutView()->AssertSubtreeIsLaidOut();
 #endif
 
   GetFrame().GetDocument()->LayoutUpdated();
   CheckDoesNotNeedLayout();
 }
 
-void FrameView::InvalidateTreeIfNeeded(
+void FrameView::DeprecatedInvalidateTree(
     const PaintInvalidationState& paint_invalidation_state) {
   DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
 
   if (ShouldThrottleRendering())
     return;
 
   Lifecycle().AdvanceTo(DocumentLifecycle::kInPaintInvalidation);
 
   RELEASE_ASSERT(!GetLayoutViewItem().IsNull());
   LayoutViewItem root_for_paint_invalidation = GetLayoutViewItem();
   ASSERT(!root_for_paint_invalidation.NeedsLayout());
 
   TRACE_EVENT1("blink", "FrameView::invalidateTree", "root",
                root_for_paint_invalidation.DebugName().Ascii());
 
   InvalidatePaint(paint_invalidation_state);
-  root_for_paint_invalidation.InvalidateTreeIfNeeded(paint_invalidation_state);
+  root_for_paint_invalidation.DeprecatedInvalidateTree(
+      paint_invalidation_state);
 
 #if DCHECK_IS_ON()
   GetLayoutView()->AssertSubtreeClearedPaintInvalidationFlags();
 #endif
 
   Lifecycle().AdvanceTo(DocumentLifecycle::kPaintInvalidationClean);
 }
 
 void FrameView::InvalidatePaint(
     const PaintInvalidationState& paint_invalidation_state) {
@@ skipping 1749 matching lines @@
       }
 
       ScrollContentsIfNeededRecursive();
       DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() ||
              Lifecycle().GetState() >= DocumentLifecycle::kCompositingClean);
 
       frame_->GetPage()->GlobalRootScrollerController().DidUpdateCompositing();
 
       if (target_state >= DocumentLifecycle::kPrePaintClean) {
         if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
-          InvalidateTreeIfNeededRecursive();
+          DeprecatedInvalidateTreeRecursive();
 
         if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
           if (view.Compositor()->InCompositingMode())
             GetScrollingCoordinator()->UpdateAfterCompositingChangeIfNeeded();
         }
 
         if (LocalFrame* local_frame = frame_->LocalFrameRoot()) {
           // This is needed since, at present, the ScrollingCoordinator doesn't
           // send rects for oopif sub-frames.
           // TODO(wjmaclean): Remove this pathway when ScrollingCoordinator
@@ skipping 272 matching lines @@
   // Ensure that we become visually non-empty eventually.
   // TODO(esprehn): This should check isRenderingReady() instead.
   if (GetFrame().GetDocument()->HasFinishedParsing() &&
       GetFrame().Loader().StateMachine()->CommittedFirstRealDocumentLoad())
     is_visually_non_empty_ = true;
 
   GetFrame().Selection().UpdateStyleAndLayoutIfNeeded();
   GetFrame().GetPage()->GetDragCaret().UpdateStyleAndLayoutIfNeeded();
 }
 
-void FrameView::InvalidateTreeIfNeededRecursive() {
+void FrameView::DeprecatedInvalidateTreeRecursive() {
   SCOPED_BLINK_UMA_HISTOGRAM_TIMER("Blink.PaintInvalidation.UpdateTime");
   {
     // For comparison to SlimmingPaintInvalidation.
     SCOPED_BLINK_UMA_HISTOGRAM_TIMER("Blink.PrePaint.UpdateTime");
-    InvalidateTreeIfNeededRecursiveInternal();
+    DeprecatedInvalidateTreeRecursiveInternal();
   }
 }
 
-void FrameView::InvalidateTreeIfNeededRecursiveInternal() {
+void FrameView::DeprecatedInvalidateTreeRecursiveInternal() {
   DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
   CHECK(GetLayoutView());
 
   // We need to stop recursing here since a child frame view might not be
   // throttled even though we are (e.g., it didn't compute its visibility yet).
   if (ShouldThrottleRendering())
     return;
   TRACE_EVENT0("blink", "FrameView::invalidateTreeIfNeededRecursiveInternal");
 
   Vector<const LayoutObject*> pending_delayed_paint_invalidations;
   PaintInvalidationState root_paint_invalidation_state(
       *GetLayoutView(), pending_delayed_paint_invalidations);
 
   if (Lifecycle().GetState() < DocumentLifecycle::kPaintInvalidationClean)
-    InvalidateTreeIfNeeded(root_paint_invalidation_state);
+    DeprecatedInvalidateTree(root_paint_invalidation_state);
 
-  // Some frames may be not reached during the above invalidateTreeIfNeeded
+  // Some frames may be not reached during the above DeprecatedInvalidateTree
   // because
   // - the frame is a detached frame; or
   // - it didn't need paint invalidation.
   // We need to call invalidateTreeIfNeededRecursiveInternal() for such frames
   // to finish required paint invalidation and advance their life cycle state.
   for (Frame* child = frame_->Tree().FirstChild(); child;
        child = child->Tree().NextSibling()) {
     if (child->IsLocalFrame()) {
       FrameView& child_frame_view = *ToLocalFrame(child)->View();
       // The children frames can be in any state, including stopping.
       // Thus we have to check that it makes sense to do paint
       // invalidation onto them here.
       if (!child_frame_view.GetLayoutView())
         continue;
-      child_frame_view.InvalidateTreeIfNeededRecursiveInternal();
+      child_frame_view.DeprecatedInvalidateTreeRecursiveInternal();
     }
   }
 
   // Process objects needing paint invalidation on the next frame. See the
   // definition of PaintInvalidationDelayedFull for more details.
   for (auto& target : pending_delayed_paint_invalidations)
     target->GetMutableForPainting().SetShouldDoFullPaintInvalidation(
         kPaintInvalidationDelayedFull);
 }
 
@@ skipping 1897 matching lines @@
 void FrameView::SetAnimationHost(
     std::unique_ptr<CompositorAnimationHost> host) {
   animation_host_ = std::move(host);
 }
 
 LayoutUnit FrameView::CaretWidth() const {
   return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
 }
 
 }  // namespace blink