Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 2851443002: Fix bug in Future.forEach. Add tests. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch, keertip
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -1 line) Patch
M sdk/lib/async/future.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/async/future_foreach_test.dart View 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-04-27 09:34:54 UTC) #2
Lasse Reichstein Nielsen
(Feel free to commit if you don't want to wait for me to do it ...
3 years, 7 months ago (2017-04-27 12:49:41 UTC) #3
floitsch
LGTM.
3 years, 7 months ago (2017-04-27 13:21:21 UTC) #4
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-04-27 14:12:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6156495d7730d8a9c5ff18a04872063a6b22daef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698