build/android/pylib/instrumentation/test_runner.py - Issue 285143002: [Android] Convert to DeviceUtils versions of IsOnline, HasRoot, and EnableRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 285143002: [Android] Convert to DeviceUtils versions of IsOnline, HasRoot, and EnableRoot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/test_runner.py

diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py

index a18c67049b694317a0432d2869111215016dc987..178509a8040ff83f9d6a5adaf66c2576fc9bbfbc 100644

--- a/build/android/pylib/instrumentation/test_runner.py

+++ b/build/android/pylib/instrumentation/test_runner.py

@@ -147,7 +147,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

def SetUp(self):

"""Sets up the test harness and device before all tests are run."""

super(TestRunner, self).SetUp()

- if not self.device.old_interface.IsRootEnabled():

+ if not self.device.HasRoot():

logging.warning('Unable to enable java asserts for %s, non rooted device',

str(self.device))

else:

« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/pylib/utils/test_environment.py » ('j') | no next file with comments »