chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java - Issue 2851313002: Adds end-to-end tests for VrShell navigation transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

Issue 2851313002: Adds end-to-end tests for VrShell navigation transitions. (Closed)

Patch Set: Rebased on ToT, incorporated review feedback 3 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java ('k') | chrome/browser/android/vr_shell/vr_shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

index d0bc08084143402e9b66f1f3ff95a3d957fc5ca4..9957059cec13a85cdccb867b96de852134831fb0 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

@@ -65,7 +65,7 @@ public class VrTestBase extends ChromeTabbedActivityTestBase {

* @param testName The name of the test whose file will be retrieved

* @return The file:// URL to the specified test file

- protected String getHtmlTestFile(String testName) {

+ protected static String getHtmlTestFile(String testName) {

return "file://" + UrlUtils.getIsolatedTestFilePath(TEST_DIR) + "/html/" + testName

+ ".html";

}