Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7265)

Unified Diff: components/download/public/clients.h

Issue 2851303003: Add the download component and initial setup (Closed)
Patch Set: Renamed the service Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/download/public/clients.h
diff --git a/components/download/public/clients.h b/components/download/public/clients.h
new file mode 100644
index 0000000000000000000000000000000000000000..bf48cfc986db8f9d5188eae6ac02567e0598ed99
--- /dev/null
+++ b/components/download/public/clients.h
@@ -0,0 +1,28 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOWNLOAD_PUBLIC_CLIENTS_H_
+#define COMPONENTS_DOWNLOAD_PUBLIC_CLIENTS_H_
+
+namespace download {
+
+// A list of all clients that are able to make download requests through the
+// DownloadService.
+// To add a new client, update the metric DownloadService.DownloadClients in
+// histograms.xml and make sure to keep this list in sync. Additions should be
+// treated as APPEND ONLY to make sure to keep both UMA metric semantics correct
+// but also to make sure the underlying database properly associates each
+// download with the right client.
+enum DownloadClient {
dcheng 2017/05/04 00:19:26 enum class here as well?
David Trainor- moved to gerrit 2017/05/04 16:15:48 Done.
+ // Represents an uninitialized DownloadClient variable.
+ DOWNLOAD_CLIENT_INVALID = 0,
+
+ DOWNLOAD_CLIENT_OFFLINE_PAGE_PREFETCH = 1,
+
+ DOWNLOAD_CLIENT_BOUNDARY = 2,
+};
+
+} // namespace download
+
+#endif // COMPONENTS_DOWNLOAD_PUBLIC_CLIENTS_H_

Powered by Google App Engine
This is Rietveld 408576698